commit f4929df99e274113eb11a6bd6fe7a8b8f2088b6e
author Hugo Arès <hugo.ares@ericsson.com> Thu Jan 21 15:11:30 2016 -0500
committer Hugo Arès <hugo.ares@ericsson.com> Thu Jan 21 15:14:03 2016 -0500
tree 8dab6f575e46f5aafba18aae8c358cf51aa9420d
parent 6a83ff45bbcbfdf200f31444400a01a863c4c857

Use try-with-resources to fix eclipse warnings

Change-Id: I68b9d5034ded87294afa5b66b395ceeb17724afa

src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java b/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java
index 17f1813..002361a 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java
@@ -375,18 +375,10 @@
   }
 
   private void runImpl() throws IOException {
-    Transport tn = Transport.open(git, uri);
     PushResult res;
-    try {
+    try (Transport tn = Transport.open(git, uri)) {
       res = pushVia(tn);
-    } finally {
-      try {
-        tn.close();
-      } catch (Throwable e2) {
-        repLog.warn("Unexpected error while closing " + uri, e2);
-      }
     }
-
     updateStates(res.getRemoteUpdates());
   }
 
@@ -506,11 +498,8 @@
 
   private Map<String, Ref> listRemote(Transport tn)
       throws NotSupportedException, TransportException {
-    FetchConnection fc = tn.openFetch();
-    try {
+    try (FetchConnection fc = tn.openFetch()) {
       return fc.getRefsMap();
-    } finally {
-      fc.close();
     }
   }