commit e7f58327b61011d04435fdddf8d539c6dcac0185
author Marcin Czech <maczech@gmail.com> Fri Apr 10 14:46:42 2020 +0200
committer Marcin Czech <maczech@gmail.com> Fri Apr 10 16:18:34 2020 +0200
tree 32230752ef7f4a3a25ea6ffa9d1f09329f8775a9
parent 1edc8418fd85eae616e72519eb880f9d0009b4b7

Fix flaky ReplicationConfig tests

Change-Id: Ic5d4b1f19a5864114697d91030b534ac6cf3f9f8

src/test/java/com/googlesource/gerrit/plugins/replication/FanoutReplicationConfigTest.java

diff --git a/src/test/java/com/googlesource/gerrit/plugins/replication/FanoutReplicationConfigTest.java b/src/test/java/com/googlesource/gerrit/plugins/replication/FanoutReplicationConfigTest.java
index 123e3e1..8cba4bb 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/replication/FanoutReplicationConfigTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/replication/FanoutReplicationConfigTest.java
@@ -85,8 +85,8 @@
     List<Destination> destinations = destinationsCollections.getAll(FilterType.ALL);
     assertThat(destinations).hasSize(2);
 
-    assertThatIsDestination(destinations.get(0), remoteName1, remoteUrl1);
-    assertThatIsDestination(destinations.get(1), remoteName2, remoteUrl2);
+    assertThatContainsDestination(destinations, remoteName1, remoteUrl1);
+    assertThatContainsDestination(destinations, remoteName2, remoteUrl2);
   }
 
   @Test

src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationFileBasedConfigTest.java

diff --git a/src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationFileBasedConfigTest.java b/src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationFileBasedConfigTest.java
index 5943757..efacae7 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationFileBasedConfigTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationFileBasedConfigTest.java
@@ -62,7 +62,7 @@
     List<Destination> destinations = destinationsCollections.getAll(FilterType.ALL);
     assertThat(destinations).hasSize(2);
 
-    assertThatIsDestination(destinations.get(0), remoteName1, remoteUrl1);
-    assertThatIsDestination(destinations.get(1), remoteName2, remoteUrl2);
+    assertThatContainsDestination(destinations, remoteName1, remoteUrl1);
+    assertThatContainsDestination(destinations, remoteName2, remoteUrl2);
   }
 }