Move ReplicationPushFilter DynamicItem to ApiModule

Bind DynamicItem of ReplicationPushFilter in the ApiModule which
effectively make it part of Cross-Plugin Communication API.

This change is backward compatible as that extension point can used in
both modes, when replication plugin is an libModule or the Cross-Plugin
Communication is used.

Change-Id: Id0ec1c6a57758b7d35e3451f647d776e3f687aa8

src/main/java/com/googlesource/gerrit/plugins/replication/ApiModule.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ApiModule.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ApiModule.java
index 38a249f..b66e95e 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/ApiModule.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ApiModule.java
@@ -20,6 +20,7 @@
 public class ApiModule extends AbstractModule {
   @Override
   protected void configure() {
+    DynamicItem.itemOf(binder(), ReplicationPushFilter.class);
     DynamicItem.itemOf(binder(), ReplicationConfigOverrides.class);
   }
 }

src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationExtensionPointModule.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationExtensionPointModule.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationExtensionPointModule.java
index 6b8706f..29e254c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationExtensionPointModule.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationExtensionPointModule.java
@@ -14,7 +14,6 @@
 
 package com.googlesource.gerrit.plugins.replication;
 
-import com.google.gerrit.extensions.registration.DynamicItem;
 import com.google.inject.AbstractModule;
 
 /**
@@ -28,6 +27,5 @@
   @Override
   protected void configure() {
     install(new ApiModule());
-    DynamicItem.itemOf(binder(), ReplicationPushFilter.class);
   }
 }

src/main/resources/Documentation/extension-point.md

diff --git a/src/main/resources/Documentation/extension-point.md b/src/main/resources/Documentation/extension-point.md
index 106b4bf..8498829 100644
--- a/src/main/resources/Documentation/extension-point.md
+++ b/src/main/resources/Documentation/extension-point.md
@@ -26,19 +26,6 @@
 Extension points
 ----------------
 
-* `com.googlesource.gerrit.plugins.replication.ReplicationPushFilter`
-
-  Filter out the ref updates pushed to a remote instance.
-  Only one filter at a time is supported. Filter implementation needs to bind a `DynamicItem`.
-
-  Default: no filtering
-
-  Example:
-
-  ```java
-  DynamicItem.bind(binder(), ReplicationPushFilter.class).to(ReplicationPushFilterImpl.class);
-  ```
-
 * `com.googlesource.gerrit.plugins.replication.AdminApiFactory`
 
   Create an instance of `AdminApi` for a given remote URL. The default implementation
@@ -90,3 +77,16 @@
   ```java
   DynamicItem.bind(binder(), ReplicationConfigOverrides.class).to(ReplicationConfigOverridesImpl.class);
   ```
+
+* `com.googlesource.gerrit.plugins.replication.ReplicationPushFilter`
+
+  Filter out the ref updates pushed to a remote instance.
+  Only one filter at a time is supported. Filter implementation needs to bind a `DynamicItem`.
+
+  Default: no filtering
+
+  Example:
+
+  ```java
+  DynamicItem.bind(binder(), ReplicationPushFilter.class).to(ReplicationPushFilterImpl.class);
+  ```