Clean up various Eclipse warnings
Change-Id: I68a9e8af7b3e7aac6b2dda2971a0f106af5d866c
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java b/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java
index 53393e8..e9ce3d4 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java
@@ -617,5 +617,5 @@
public LockFailureException(URIish uri, String message) {
super(uri, message);
}
- };
+ }
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java b/src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java
index 56c5d39..954a175 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java
@@ -41,10 +41,20 @@
abstract void onAllRefsReplicatedToAllNodes(int totalPushTasksCount);
+ /**
+ * Write message to standard out.
+ *
+ * @param message message text.
+ */
void writeStdOut(final String message) {
// Default doing nothing
}
+ /**
+ * Write message to standard error.
+ *
+ * @param message message text.
+ */
void writeStdErr(final String message) {
// Default doing nothing
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationFileBasedConfig.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationFileBasedConfig.java
index 57d07b8..574778e 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationFileBasedConfig.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationFileBasedConfig.java
@@ -184,6 +184,7 @@
return cfgPath;
}
+ @Override
public int shutdown() {
int discarded = 0;
for (Destination cfg : destinations) {
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java
index a976d74..003b8a9 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java
@@ -30,7 +30,6 @@
import com.googlesource.gerrit.plugins.replication.PushResultProcessing.GitUpdateProcessing;
-import org.eclipse.jgit.errors.ConfigInvalidException;
import org.eclipse.jgit.errors.TransportException;
import org.eclipse.jgit.internal.storage.file.FileRepository;
import org.eclipse.jgit.lib.Constants;
@@ -85,8 +84,7 @@
@Inject
ReplicationQueue(final WorkQueue wq, final ReplicationConfig rc,
- final SchemaFactory<ReviewDb> db, final ChangeHooks ch)
- throws ConfigInvalidException, IOException {
+ final SchemaFactory<ReviewDb> db, final ChangeHooks ch) {
workQueue = wq;
database = db;
changeHooks = ch;
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/SecureCredentialsFactory.java b/src/main/java/com/googlesource/gerrit/plugins/replication/SecureCredentialsFactory.java
index 68433f1..32d3905 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/SecureCredentialsFactory.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/SecureCredentialsFactory.java
@@ -51,6 +51,7 @@
return cfg;
}
+ @Override
public SecureCredentialsProvider create(String remoteName) {
String user = config.getString("remote", remoteName, "username");
String pass = config.getString("remote", remoteName, "password");
diff --git a/src/test/java/com/googlesource/gerrit/plugins/replication/GitUpdateProcessingTest.java b/src/test/java/com/googlesource/gerrit/plugins/replication/GitUpdateProcessingTest.java
index 6b6e616..52362fd 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/replication/GitUpdateProcessingTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/replication/GitUpdateProcessingTest.java
@@ -53,6 +53,7 @@
private ChangeAccess changeAccessMock;
private GitUpdateProcessing gitUpdateProcessing;
+ @Override
protected void setUp() throws Exception {
super.setUp();
changeHooksMock = createMock(ChangeHooks.class);
@@ -105,7 +106,7 @@
verify(changeHooksMock);
}
- public void testOnAllNodesReplicated() throws URISyntaxException {
+ public void testOnAllNodesReplicated() {
reset(changeHooksMock);
RefReplicationDoneEvent expectedDoneEvent =
new RefReplicationDoneEvent("someProject", "refs/heads/master", 5);
