ReplicationIT: Remove unnecessary storage inspection Integration tests shouldn't need to rely on inspecting the underlying ReplicationTasksStorage layer(s). All of these tests already verify the expected end result. This leaves 4 tests that currently completely rely on inspecting the task storage to verify the expected result. Those tests need further improvement to decouple from the storage layer. Change-Id: I029d63ce7d07414d9bf5d9290d556378beedcabf
diff --git a/src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationIT.java b/src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationIT.java index f0ea138..89ee20a 100644 --- a/src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationIT.java +++ b/src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationIT.java
@@ -107,8 +107,6 @@ Project.NameKey sourceProject = createTestProject("foo"); - assertThat(listReplicationTasks("refs/meta/config")).hasSize(1); - WaitUtil.waitUntil( () -> nonEmptyProjectExists(new Project.NameKey(sourceProject + "replica.git")), TEST_NEW_PROJECT_TIMEOUT); @@ -156,8 +154,6 @@ RevCommit sourceCommit = pushResult.getCommit(); String sourceRef = pushResult.getPatchSet().getRefName(); - assertThat(listReplicationTasks("refs/changes/\\d*/\\d*/\\d*")).hasSize(1); - try (Repository repo = repoManager.openRepository(targetProject)) { waitUntil(() -> checkedGetRef(repo, sourceRef) != null); @@ -179,8 +175,6 @@ input.revision = master; gApi.projects().name(project.get()).branch(newBranch).create(input); - assertThat(listReplicationTasks("refs/heads/(mybranch|master)")).hasSize(2); - try (Repository repo = repoManager.openRepository(targetProject); Repository sourceRepo = repoManager.openRepository(project)) { waitUntil(() -> checkedGetRef(repo, newBranch) != null); @@ -205,8 +199,6 @@ RevCommit sourceCommit = pushResult.getCommit(); String sourceRef = pushResult.getPatchSet().getRefName(); - assertThat(listReplicationTasks("refs/changes/\\d*/\\d*/\\d*")).hasSize(2); - try (Repository repo1 = repoManager.openRepository(targetProject1); Repository repo2 = repoManager.openRepository(targetProject2)) { waitUntil(