Use switch-statement in ReplicateRefUpdateTypeAdapter.read() Change-Id: I04db0b3f77f96a83488fca034c5fa764071b72bb
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationTasksStorage.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationTasksStorage.java index 7149cce..9e736ea 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationTasksStorage.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationTasksStorage.java
@@ -275,26 +275,32 @@ fieldname = in.nextName(); } - if ("project".equals(fieldname)) { - project = in.nextString(); - } else if ("refs".equals(fieldname)) { - in.beginArray(); - while (in.hasNext()) { + switch (fieldname) { + case "project": + project = in.nextString(); + break; + case "refs": + in.beginArray(); + while (in.hasNext()) { + refs.add(in.nextString()); + } + in.endArray(); + break; + case "ref": refs.add(in.nextString()); - } - in.endArray(); - } else if ("ref".equals(fieldname)) { - refs.add(in.nextString()); - } else if ("uri".equals(fieldname)) { - try { - uri = new URIish(in.nextString()); - } catch (URISyntaxException e) { - throw new IOException("Unable to parse remote URI", e); - } - } else if ("remote".equals(fieldname)) { - remote = in.nextString(); - } else { - throw new IOException(String.format("Unknown field in stored task: %s", fieldname)); + break; + case "uri": + try { + uri = new URIish(in.nextString()); + } catch (URISyntaxException e) { + throw new IOException("Unable to parse remote URI", e); + } + break; + case "remote": + remote = in.nextString(); + break; + default: + throw new IOException(String.format("Unknown field in stored task: %s", fieldname)); } }