commit 30fe5d82b1e3041fbd4a7265ef42a61b394e17c6
author David Ostrovsky <david.ostrovsky@gmail.com> Sun Mar 20 22:41:51 2016 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Sun Mar 20 22:41:51 2016 +0000
tree b1070153c53c7a1a607c10c9481afc5265d000ad
parent e96d2f33f7e7068b01fce8e6f3aa7dc409f90667
parent b68c4322097301dff2a7df6830327707089c07e6

Merge "Remove unneeded finals from Destination class"

src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java b/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java
index 316c8df..e25b32a 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java
@@ -115,20 +115,20 @@
   private final ReplicationMetrics metrics;
 
   @Inject
-  PushOne(final GitRepositoryManager grm,
-      final SchemaFactory<ReviewDb> s,
-      final Destination p,
-      final RemoteConfig c,
-      final CredentialsFactory cpFactory,
-      final TagCache tc,
-      final PerThreadRequestScope.Scoper ts,
-      final ChangeCache cc,
-      final ReplicationQueue rq,
-      final IdGenerator ig,
-      final ReplicationStateListener sl,
-      final ReplicationMetrics m,
-      @Assisted final Project.NameKey d,
-      @Assisted final URIish u) {
+  PushOne(GitRepositoryManager grm,
+      SchemaFactory<ReviewDb> s,
+      Destination p,
+      RemoteConfig c,
+      CredentialsFactory cpFactory,
+      TagCache tc,
+      PerThreadRequestScope.Scoper ts,
+      ChangeCache cc,
+      ReplicationQueue rq,
+      IdGenerator ig,
+      ReplicationStateListener sl,
+      ReplicationMetrics m,
+      @Assisted Project.NameKey d,
+      @Assisted URIish u) {
     gitManager = grm;
     schema = s;
     pool = p;
@@ -306,7 +306,7 @@
       // Tried to replicate to a remote via anonymous git:// but the repository
       // does not exist.  In this case NoRemoteRepositoryException is not
       // raised.
-      final String msg = e.getMessage();
+      String msg = e.getMessage();
       if (msg.contains("access denied") || msg.contains("no such repository")) {
         createRepository();
       } else {
@@ -357,7 +357,7 @@
   private void createRepository() {
     if (pool.isCreateMissingRepos()) {
       try {
-        final Ref head = git.exactRef(Constants.HEAD);
+        Ref head = git.exactRef(Constants.HEAD);
         if (replicationQueue.createProject(projectName, head != null ? head.getName() : null)) {
           repLog.warn("Missing repository created; retry replication to " + uri);
           pool.reschedule(this, Destination.RetryReason.REPOSITORY_MISSING);