commit 13cefb724df786d254ecbc24261589ab473be267
author Nasser Grainawi <nasser@codeaurora.org> Mon May 10 15:39:30 2021 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon May 10 15:39:30 2021 +0000
tree 65c30de335fe3c8d5d440846eb36f3f787b39af4
parent 5774ae2eb58299465916ee1f50ca05545de8b2a0
parent cfeacabccb5c40645d9bd837768d171ab4ef1c74

Merge "ReplicationState: Streamline getRefStatus()"

src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java
index 871ed52..fa65803 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java
@@ -140,12 +140,12 @@
   }
 
   private RefReplicationStatus getRefStatus(String project, String ref) {
-    if (!statusByProjectRef.contains(project, ref)) {
-      RefReplicationStatus refStatus = new RefReplicationStatus(project, ref);
+    RefReplicationStatus refStatus = statusByProjectRef.get(project, ref);
+    if (refStatus == null) {
+      refStatus = new RefReplicationStatus(project, ref);
       statusByProjectRef.put(project, ref, refStatus);
-      return refStatus;
     }
-    return statusByProjectRef.get(project, ref);
+    return refStatus;
   }
 
   public void waitForReplication() throws InterruptedException {