commit 0995fe0445f507279c05cb5ee60a9413671be400
author Sven Selberg <svense@axis.com> Thu Dec 17 10:18:37 2020 +0100
committer Sven Selberg <sven.selberg@axis.com> Mon Dec 21 11:45:54 2020 +0000
tree 282a50e34b7618a443aa089c127fe06558ff05e6
parent c4df2f1eb9fe470debf4958e05cf29c2ec314b43

Don't check read permission when authgroup isn't set

It's unnecessary to check read permission when authGroup isn't set since
the then the user is a RemoteSiteUser that is-an InternalUser that has
read access to everything.

Change-Id: Ie6985250b0acb50c08fdcae75cc608222b1add35

src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java b/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java
index 5e7b6b8..62ea42b 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java
@@ -329,6 +329,9 @@
                 if (PushOne.ALL_REFS.equals(ref)) {
                   return true;
                 }
+                if (userProvider.get().isInternalUser()) {
+                  return true;
+                }
                 try {
                   permissionBackend
                       .user(userProvider.get())