Merge branch 'stable-3.0' into stable-3.1 * stable-3.0: Upgrade bazlets to latest stable-3.0 to build with 3.0.10 API Upgrade bazlets to latest stable-2.16 to build with 2.16.21 API Upgrade bazlets to latest stable-2.15 to build with 2.15.19 API Upgrade bazlets to latest stable-2.14 to build with 2.14.21 API Change-Id: I3807f462a14a17173acd93eb8b4e2a7753d71ef1
diff --git a/WORKSPACE b/WORKSPACE index 7cd0410..f7e0b8e 100644 --- a/WORKSPACE +++ b/WORKSPACE
@@ -3,7 +3,7 @@ load("//:bazlets.bzl", "load_bazlets") load_bazlets( - commit = "928c928345646ae958b946e9bbdb462f58dd1384", + commit = "51c1fd2758fcc1b900a80d4ebb037bc373f85d39", #local_path = "/home/<user>/projects/bazlets", )
diff --git a/src/main/java/com/googlesource/gerrit/plugins/readonly/ReadOnlyEndpoint.java b/src/main/java/com/googlesource/gerrit/plugins/readonly/ReadOnlyEndpoint.java index 2482cab..6a4b916 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/readonly/ReadOnlyEndpoint.java +++ b/src/main/java/com/googlesource/gerrit/plugins/readonly/ReadOnlyEndpoint.java
@@ -40,8 +40,8 @@ } @Override - public String apply(ConfigResource resource) { - return state.isReadOnly() ? "on" : "off"; + public Response<String> apply(ConfigResource resource) { + return Response.ok(state.isReadOnly() ? "on" : "off"); } }
diff --git a/src/test/java/com/googlesource/gerrit/plugins/readonly/AbstractReadOnlyTest.java b/src/test/java/com/googlesource/gerrit/plugins/readonly/AbstractReadOnlyTest.java index 56be07a..b14bcce 100644 --- a/src/test/java/com/googlesource/gerrit/plugins/readonly/AbstractReadOnlyTest.java +++ b/src/test/java/com/googlesource/gerrit/plugins/readonly/AbstractReadOnlyTest.java
@@ -15,6 +15,7 @@ package com.googlesource.gerrit.plugins.readonly; import static com.google.common.truth.Truth.assertThat; +import static com.google.gerrit.testing.GerritJUnit.assertThrows; import static org.apache.http.HttpStatus.SC_SERVICE_UNAVAILABLE; import com.google.gerrit.acceptance.GitUtil; @@ -146,12 +147,9 @@ setReadOnly(true); // Push should fail - try { - pushTo("refs/for/master"); - fail("expected TransportException"); - } catch (TransportException e) { - assertThat(e).hasMessageThat().contains(expectedMessage); - } + TransportException thrown = + assertThrows(TransportException.class, () -> pushTo("refs/for/master")); + assertThat(thrown).hasMessageThat().contains(expectedMessage); // Disable read-only setReadOnly(false);