Extract compiled pattern to a constant
Given the regex is constant, there is no need to compile a new pattern
every time the method is called.
Change-Id: Ica43c0850b00be19d42c3850b572f881b4622d8b
diff --git a/src/main/java/com/googlesource/gerrit/plugins/quota/AccountLimitsConfig.java b/src/main/java/com/googlesource/gerrit/plugins/quota/AccountLimitsConfig.java
index 7044845..2475d21 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/quota/AccountLimitsConfig.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/quota/AccountLimitsConfig.java
@@ -34,6 +34,8 @@
public class AccountLimitsConfig {
private static final int DEFAULT_BURST_COUNT = 30;
private static final int DEFAULT_INTERVAL_SECONDS = 60;
+ private static final Pattern PATTERN =
+ Pattern.compile("^\\s*(\\d+)\\s*/\\s*(.*)\\s*burst\\s*(\\d+)$");
private static final Logger log =
LoggerFactory.getLogger(AccountLimitsConfig.class);
static final String GROUP_SECTION = "group";
@@ -105,8 +107,7 @@
return defaultRateLimit(type);
}
- Matcher m = Pattern.compile("^\\s*(\\d+)\\s*/\\s*(.*)\\s*burst\\s*(\\d+)$")
- .matcher(value);
+ Matcher m = PATTERN.matcher(value);
if (!m.matches()) {
log.warn(
"Invalid ''{}'' ratelimit configuration ''{}'', use default ratelimit {}/hour",
