Fix CheckStyle warnings
- Add missing braces around if-block
- Remove redundant 'public' modifier on constructors and interface methods
- Use uppercase 'L' for long values
Change-Id: I0c92583d2ef2e6faec19c080d1923308b512e147
diff --git a/src/main/java/com/googlesource/gerrit/plugins/quota/MaxRepositorySizeQuota.java b/src/main/java/com/googlesource/gerrit/plugins/quota/MaxRepositorySizeQuota.java
index f23d11f..e9a1973 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/quota/MaxRepositorySizeQuota.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/quota/MaxRepositorySizeQuota.java
@@ -134,8 +134,9 @@
private boolean needPack(Collection<ReceiveCommand> commands) {
for (ReceiveCommand cmd : commands) {
- if (cmd.getType() != ReceiveCommand.Type.DELETE)
+ if (cmd.getType() != ReceiveCommand.Type.DELETE) {
return true;
+ }
}
return false;
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/quota/MetaDataImpl.java b/src/main/java/com/googlesource/gerrit/plugins/quota/MetaDataImpl.java
index 194241c..ae952f8 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/quota/MetaDataImpl.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/quota/MetaDataImpl.java
@@ -23,7 +23,7 @@
private String unitSymbol;
private String description;
- public MetaDataImpl(String name, String unitName, String unitSymbol, String description) {
+ MetaDataImpl(String name, String unitName, String unitSymbol, String description) {
this.name = name;
this.unitName = unitName;
this.unitSymbol = unitSymbol;
diff --git a/src/main/java/com/googlesource/gerrit/plugins/quota/UsageDataEvent.java b/src/main/java/com/googlesource/gerrit/plugins/quota/UsageDataEvent.java
index 8dfaa55..d37709c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/quota/UsageDataEvent.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/quota/UsageDataEvent.java
@@ -28,7 +28,7 @@
private final MetaData metaData;
private final List<Data> data;
- public UsageDataEvent(MetaData metaData) {
+ UsageDataEvent(MetaData metaData) {
this.metaData = metaData;
timestamp = new Timestamp(System.currentTimeMillis());
data = new ArrayList<>();
diff --git a/src/main/java/com/googlesource/gerrit/plugins/quota/UsageDataEventCreator.java b/src/main/java/com/googlesource/gerrit/plugins/quota/UsageDataEventCreator.java
index 5ad42b9..56db9b3 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/quota/UsageDataEventCreator.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/quota/UsageDataEventCreator.java
@@ -18,8 +18,8 @@
public interface UsageDataEventCreator {
- public String getName();
+ String getName();
- public UsageDataPublishedListener.Event create();
+ UsageDataPublishedListener.Event create();
}
diff --git a/src/test/java/com/googlesource/gerrit/plugins/quota/GCListenerTest.java b/src/test/java/com/googlesource/gerrit/plugins/quota/GCListenerTest.java
index f59bbc1..f8df792 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/quota/GCListenerTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/quota/GCListenerTest.java
@@ -39,15 +39,15 @@
@Test
public void testEventWithStatistics() {
RepoSizeCache repoSizeCache = createMock(RepoSizeCache.class);
- repoSizeCache.set(new Project.NameKey(PROJECT_NAME), 9999l);
+ repoSizeCache.set(new Project.NameKey(PROJECT_NAME), 9999L);
expectLastCall();
replay(repoSizeCache);
GCListener listener = new GCListener(repoSizeCache);
final Properties statistics = new Properties();
- statistics.put("sizeOfLooseObjects", 1234l);
- statistics.put("sizeOfPackedObjects", 8765l);
+ statistics.put("sizeOfLooseObjects", 1234L);
+ statistics.put("sizeOfPackedObjects", 8765L);
listener.onGarbageCollected(createEvent(PROJECT_NAME, statistics));
diff --git a/src/test/java/com/googlesource/gerrit/plugins/quota/RepoSizeEventCreatorTest.java b/src/test/java/com/googlesource/gerrit/plugins/quota/RepoSizeEventCreatorTest.java
index f67f776..fc72e9a 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/quota/RepoSizeEventCreatorTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/quota/RepoSizeEventCreatorTest.java
@@ -75,7 +75,7 @@
@Test
public void testOneDataPoint() {
- expect(repoSizeCache.get(p1)).andStubReturn(100l);
+ expect(repoSizeCache.get(p1)).andStubReturn(100L);
replay(repoSizeCache);
Event event = classUnderTest.create();
@@ -84,7 +84,7 @@
assertEquals(1, event.getData().size());
Data dataPoint = event.getData().get(0);
assertEquals("p1", dataPoint.getProjectName());
- assertEquals(100l, dataPoint.getValue());
+ assertEquals(100L, dataPoint.getValue());
}
}
