commit f965e5a4ed1ff67ce7e783e71d503f9bd28bd493
author Luca Milanesio <luca.milanesio@gmail.com> Thu Mar 23 23:31:18 2023 +0000
committer Luca Milanesio <luca.milanesio@gmail.com> Tue Mar 28 21:57:04 2023 +0000
tree 7c68891778c52c908f2b7b6a2bc6786e4d8cb484
parent 99a68667b239046731027330252c5f73124559db

Restore the fetching of all refs with empty delta

When the FetchOne's delta is empty the fetching should run
with all refs. This fixes a regression introduced by I093ce3a7
when the recover from failed fetch of individual refs has
mistakenly skipped also the all refs fetching.

Change-Id: I3ea2769d7819b2b79ec2d4f2b9514fc91dee7c3e

src/main/java/com/googlesource/gerrit/plugins/replication/pull/FetchOne.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/FetchOne.java b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/FetchOne.java
index c028d84..3467460 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/FetchOne.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/FetchOne.java
@@ -417,11 +417,6 @@
   }
 
   private void runImpl() throws IOException {
-    if (delta.isEmpty()) {
-      repLog.warn("Empty replication task [{}], skipping.", taskIdHex);
-      return;
-    }
-
     Fetch fetch = fetchFactory.create(taskIdHex, uri, git);
     List<RefSpec> fetchRefSpecs = getFetchRefSpecs();
 
@@ -436,6 +431,11 @@
           inexistentRef);
       fetchFailures.add(e);
       delta.remove(inexistentRef);
+      if (delta.isEmpty()) {
+        repLog.warn("[{}] Empty replication task, skipping.", taskIdHex);
+        return;
+      }
+
       runImpl();
     }
   }