Reduce default exclude refs filter
Users, groups and config refs should be replicated by default, this is
also how replication plugin works. This is unexpected, that extra steps
are needed to make those standard refs replicated with pull replication
plugin.
Change-Id: I22a6d632e9a5c6f0ff65f97b623824d16a970ef0
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/filter/ExcludedRefsFilter.java b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/filter/ExcludedRefsFilter.java
index 63755b4..4847446 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/filter/ExcludedRefsFilter.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/filter/ExcludedRefsFilter.java
@@ -25,16 +25,7 @@
@Singleton
public class ExcludedRefsFilter extends RefsFilter {
public static String[] DEFAULT_REPLICATION_EXCLUDE_REFS =
- new String[] {
- RefNames.REFS_USERS + "*",
- RefNames.REFS_CONFIG,
- RefNames.REFS_SEQUENCES + "*",
- RefNames.REFS_EXTERNAL_IDS,
- RefNames.REFS_GROUPS + "*",
- RefNames.REFS_GROUPNAMES,
- RefNames.REFS_CACHE_AUTOMERGE + "*",
- RefNames.REFS_STARRED_CHANGES + "*"
- };
+ new String[] {RefNames.REFS_CACHE_AUTOMERGE + "*", RefNames.REFS_STARRED_CHANGES + "*"};
@Inject
public ExcludedRefsFilter(ReplicationConfig replicationConfig) {
diff --git a/src/test/java/com/googlesource/gerrit/plugins/replication/pull/ReplicationQueueTest.java b/src/test/java/com/googlesource/gerrit/plugins/replication/pull/ReplicationQueueTest.java
index 48e0e71..464bc9c 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/replication/pull/ReplicationQueueTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/replication/pull/ReplicationQueueTest.java
@@ -275,38 +275,6 @@
}
@Test
- public void shouldSkipEventWhenUsersRef() {
- Event event = new TestEvent("refs/users/00/1000000");
- objectUnderTest.onGitReferenceUpdated(event);
-
- verifyZeroInteractions(wq, rd, dis, sl, fetchClientFactory, accountInfo);
- }
-
- @Test
- public void shouldSkipEventWhenGroupsRef() {
- Event event = new TestEvent("refs/groups/a1/a16d5b33cc789d60b682c654f03f9cc2feb12975");
- objectUnderTest.onGitReferenceUpdated(event);
-
- verifyZeroInteractions(wq, rd, dis, sl, fetchClientFactory, accountInfo);
- }
-
- @Test
- public void shouldSkipEventWhenGroupNamesRef() {
- Event event = new TestEvent("refs/meta/group-names");
- objectUnderTest.onGitReferenceUpdated(event);
-
- verifyZeroInteractions(wq, rd, dis, sl, fetchClientFactory, accountInfo);
- }
-
- @Test
- public void shouldSkipEventWhenMultiSequenceRef() {
- Event event = new TestEvent("refs/sequences/changes");
- objectUnderTest.onGitReferenceUpdated(event);
-
- verifyZeroInteractions(wq, rd, dis, sl, fetchClientFactory, accountInfo);
- }
-
- @Test
public void shouldSkipEventWhenMultiSiteVersionRef() throws IOException {
FileBasedConfig fileConfig =
new FileBasedConfig(sitePaths.etc_dir.resolve("replication.config").toFile(), FS.DETECTED);
@@ -341,22 +309,6 @@
}
@Test
- public void shouldSkipEventWhenConfigRef() {
- Event event = new TestEvent("refs/meta/config");
- objectUnderTest.onGitReferenceUpdated(event);
-
- verifyZeroInteractions(wq, rd, dis, sl, fetchClientFactory, accountInfo);
- }
-
- @Test
- public void shouldSkipEventWhenExternalIdsRef() {
- Event event = new TestEvent("refs/meta/external-ids");
- objectUnderTest.onGitReferenceUpdated(event);
-
- verifyZeroInteractions(wq, rd, dis, sl, fetchClientFactory, accountInfo);
- }
-
- @Test
public void shouldCallDeleteWhenReplicateProjectDeletionsTrue() throws IOException {
when(source.wouldDeleteProject(any())).thenReturn(true);
