Fixed erroneous increment of the rescheduled metric Rescheduled metric was incorrectly incremented during merge. Change-Id: I9007b28a2a13c5df527e214b8ba38008dc1252eb
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/Source.java b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/Source.java index a5d1e9e..0a75288 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/Source.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/Source.java
@@ -641,8 +641,6 @@ fetchOp.getTaskIdHex(), fetchOp.getURI(), pendingFetchOp.getTaskIdHex()), fetchOp.getStatesAsArray()); - queueMetrics.incrementTaskRescheduled(this); - } else { // The one pending is one that is NOT retrying, it was just // scheduled believing no problem would happen. The one pending @@ -682,9 +680,8 @@ "[%s] Merging the pending fetch from [%s] with task [%s] and rescheduling", pendingFetchOp.getTaskIdHex(), pendingFetchOp.getURI(), fetchOp.getTaskIdHex()), pendingFetchOp.getStatesAsArray()); - - queueMetrics.incrementTaskMerged(this); } + queueMetrics.incrementTaskMerged(this); } if (pendingFetchOp == null || !pendingFetchOp.isRetrying()) {