commit e5a3a58944d1d634da03112a3f5a362ca0cb92f7
author Vasyl Vavrychuk <vvavrychuk@gmail.com> Mon Jun 29 04:57:04 2020 +0300
committer Nguyen Tuan Khang Phan <nguyen.tuan.khang.phan@ericsson.com> Mon Jul 13 12:30:43 2020 +0000
tree a607fcaa7097488926cd8f012b0c522478280dfd
parent fd8b26a4684126e9e11c522bedc52eb0259d7ffd

ProjectCreationValidator: Bypass spaces check in project name for admins

All of behaviour of project-group-structure plugin was bypassed for
admins, except whitespace check in project name. Bypass whitespace check
too for consistency reasons.

Change-Id: I343c9ad267da4753b17a19a4ce7cbdb3b930a084

src/main/java/com/ericsson/gerrit/plugins/projectgroupstructure/ProjectCreationValidator.java

diff --git a/src/main/java/com/ericsson/gerrit/plugins/projectgroupstructure/ProjectCreationValidator.java b/src/main/java/com/ericsson/gerrit/plugins/projectgroupstructure/ProjectCreationValidator.java
index 331c968..c93819f 100644
--- a/src/main/java/com/ericsson/gerrit/plugins/projectgroupstructure/ProjectCreationValidator.java
+++ b/src/main/java/com/ericsson/gerrit/plugins/projectgroupstructure/ProjectCreationValidator.java
@@ -114,12 +114,6 @@
   public void validateNewProject(CreateProjectArgs args) throws ValidationException {
     String name = args.getProjectName();
     log.debug("validating creation of {}", name);
-    if (name.contains(" ")) {
-      throw new ValidationException(
-          String.format(PROJECT_CANNOT_CONTAINS_SPACES_MSG, documentationUrl));
-    }
-
-    Project.NameKey newParent = args.newParent;
 
     try {
       permissionBackend.user(self.get()).check(GlobalPermission.ADMINISTRATE_SERVER);
@@ -134,6 +128,13 @@
       // continuing
     }
 
+    if (name.contains(" ")) {
+      throw new ValidationException(
+          String.format(PROJECT_CANNOT_CONTAINS_SPACES_MSG, documentationUrl));
+    }
+
+    Project.NameKey newParent = args.newParent;
+
     if (allProjectsName.get().equals(newParent)) {
       validateRootProject(name, args.permissionsOnly);
     } else {