tag df60eb0c2f7eb9476b5d6b00f01548a3b8d50d9e
tagger Luca Milanesio <luca.milanesio@gmail.com> Sat Apr 25 01:33:47 2020 +0000
object 2933add62ecf2cbfc28cfe2cff81ff0e0eecc913

v3.2.0-rc0

commit 2933add62ecf2cbfc28cfe2cff81ff0e0eecc913
author Edwin Kempin <ekempin@google.com> Mon Dec 23 14:24:40 2019 +0100
committer Edwin Kempin <ekempin@google.com> Mon Dec 23 14:32:12 2019 +0100
tree b13aac578713fecd55ca1bfc5b3b9893a7318cb4
parent 828d666bbb4aae1a2c348a12d7855ec5db3be46f

Do not throw generic RestApiException to signal an internal server error

Just throw the ExecutionException which will be mapped to internal
server error too. This removes the specific exception message, but the
same information is available from the stacktrace which will be logged.
Since this was an internal server error, the message wasn't returned to
clients anyway.

Throwing RestApiExceptions to signal internal server errors is bad
since all RestApiExceptions are exempt from retries and auto-tracing.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ie2b167f72c3b659d32f2027c74dbcfb9a95dee04