Set version to v2.14.1
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEmCU49QQ43XtIE8giC0731aK2mH4FAl4GpjoACgkQC0731aK2
mH7uWQ//bsTEBGLa3Kl1NJ6zqfVgWP1y93FgDI9Fr5m0GShWw5/4QFrBQf2nAN7b
iLM9C/fpdXfC7tIzDwHAO+GxUSaEfyO9mnQknuGUYhXtW8G04f1svD23Yw2XZnVv
r28A7GX9hH/NcUTuIVxp6FhoijekXRvP6Vq5c5tuH2nyYAqfQKlY7CRIY/0PPfHL
iRPf9eNjr9akO53L4MVAhm/F0GOrFi/XWtZ2EWaJuoL8UK3oKOKyLeYXJdjpuKo1
B7dVeUKvrGgQPeBPFamWY9VTasmFpNni6PBqP55pBypH2s+LF8oRRhw9FAQJhZNN
+ADtE1GmATS3YhvY4p233YNK2tK+q6uBaSaYVPJAfiZAjr1J+X9B1CgDXMjazGNo
BAQ0bbsx8bZyVlAOSI+WutQK2lhwZAkSayuwufunp7uJUkVrpq2vd404X1USD0DE
yOtba7VJ/b7q8N18qG34U+liNQQ5/ChOSr3l82nadvscBOrfMdPaIIdru07r7k1v
Ttm//3dEiQszbplCwlkIX61v+FSTWwYYJJYGoJKCoeC6/qcHHZdSRlY0f70TLyww
FYqYUO6gCfW/kV9Yuhg07RAp4I8N+r0bOCLX6OHVLMMKlMw6LROmMvOKn4htYyLY
U41Y0pg5MwNSWLBO+27rdMxxsdnmGu1dLoSS6KD9ev/Q3+d0xY0=
=DYdz
-----END PGP SIGNATURE-----
Do not assign reviewers that cannot see the change

When assigning reviewers to a change automatically, do not
include the ones that have no read visibility to the change
ref. Trying to assign users that cannot see the change would
result in throwing an exception and would thus break the entire
functionality of auto-assigning reviewers to a change.

Keep the message of the users not assigned to a change
as a warning so that the Gerrit admin could understand the problem
and adjust the ACLs if needed.

Bug: Issue 12118
Change-Id: Id84d10d13cb3a5291d7275b2ad24e4686464380d
1 file changed
tree: 85bf5c13a400f54372b4881bb83ade276cb87bd6
  1. .bazelignore
  2. .bazelrc
  3. .gitignore
  4. .settings/
  5. BUILD
  6. CHANGELOG
  7. LICENSE
  8. README.md
  9. WORKSPACE
  10. bazlets.bzl
  11. config.md
  12. external_plugin_deps.bzl
  13. external_plugin_deps_standalone.bzl
  14. lib/
  15. owners-autoassign/
  16. owners-common/
  17. owners/
  18. tools/
README.md

Gerrit OWNERS Plugin

This plugin provides some Prolog predicates that can be used to add customized validation checks based on the approval of ‘path owners’ of a particular folder in the project.

That allows creating a single big project including multiple components and users have different roles depending on the particular path where changes are being proposed. A user can be “owner” in a specific directory, and thus influencing the approvals of changes there, but cannot do the same in others paths, so assuring a kind of dynamic subproject access rights.

How it works

There are currently two main prolog public verbs:

add_owner_approval/3 (UserList, InList, OutList) appends label('Owner-Approval', need(_)) to InList building OutList if UserList has no users contained in the defined owners of this path change.

In other words, the predicate just copies InList to OutList if at least one of the elements in UserList is an owner.

add_owner_approval/2 (InList, OutList) appends label('Owner-Approval', need(_)) to InList building OutList if no owners has given a Code-Review +2 to this path change.

This predicate is similar to the first one but generates a UserList with an hardcoded policy.

Since add_owner_approval/3 is not using hard coded policies, it can be suitable for complex customizations.

Auto assigner

There is a second plugin, gerrit-owners-autoassign which depends on gerrit-owners. It will automatically assign all of the owners to review a change when it's created or updated.

How to build

This plugin is built with Bazel and two build modes are supported:

  • Standalone
  • In Gerrit tree

Build standalone

To build the plugin, issue the following command:

  bazel build :all

The output is created in

  bazel-genfiles/owners/owners.jar
  bazel-genfiles/owners-autoassign/owners-autoassign.jar

To execute the tests run:

  bazel test //...

This project can be imported into the Eclipse IDE:

  ./tools/eclipse/project.sh

Build in Gerrit tree

Create symbolic links of the owners and owners-autoassign folders and of the external_plugin_deps.bzl file to the Gerrit source code /plugins directory.

Create a symbolic link of the owners-common plugin to the Gerrit source code directory.

Then build the owners and owners-autoassign plugins with the usual Gerrit plugin compile command.

Example:

   $ git clone https://gerrit.googlesource.com/plugins/owners
   $ git clone https://gerrit.googlesource.com/gerrit
   $ cd gerrit/plugins
   $ ln -s ../../owners/owners .
   $ ln -s ../../owners/owners-autoassign .
   $ ln -sf ../../owners/external_plugin_deps.bzl .
   $ cd ..
   $ ln -s ../owners/owners-common .
   $ bazel build plugins/owners plugins/owners-autoassign

NOTE: the owners-common folder is producing shared artifacts for the two plugins and does not need to be built separately being a direct dependency of the build process. Its resulting .jar must not be installed in gerrit plugins directory.

The output is created in

  bazel-genfiles/plugins/owners/owners.jar
  bazel-genfiles/plugins/owners-autoassign/owners-autoassign.jar

To execute the tests run:

  bazel test owners-common:test

This project can be imported into the Eclipse IDE:

Add the plugin name to the CUSTOM_PLUGINS in Gerrit core in tools/bzl/plugins.bzl file and run:

  ./tools/eclipse/project.py