| commit | f24b1a2a5b84895090775b8002d703e0ee1c8dbb | [log] [tgz] |
|---|---|---|
| author | Benoit Perrot <be.perrot@criteo.com> | Mon Dec 12 14:42:47 2016 +0100 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Tue Dec 13 16:03:08 2016 +0000 |
| tree | be4ef7a402d9073f5fe7042750576ee2b30332cf | |
| parent | 6098f611b8328f1e881111d01e549d68479b7d4b [diff] |
Stop depending on gitective. The feature offered by "gitective" can be implemented in ~30 lines of code, so prefer implementing it here - removing the dependency on gitective, making the dependency against jgit API direct for better detection of API breaking changes impact. Change-Id: Icaef2992bcf5889d7b9fae0f02662ae3298a660d
This plugin provides some Prolog predicates that can be used to add customized validation checks based on the approval of ‘path owners’ of a particular folder in the project.
That allows creating a single big project including multiple components and users have different roles depending on the particular path where changes are being proposed. A user can be “owner” in a specific directory, and thus influencing the approvals of changes there, but cannot do the same in others paths, so assuring a kind of dynamic subproject access rights.
There are currently two main prolog public verbs:
add_owner_approval/3 (UserList, InList, OutList) appends label('Owner-Approval', need(_)) to InList building OutList if UserList has no users contained in the defined owners of this path change.
In other words, the predicate just copies InList to OutList if at least one of the elements in UserList is an owner.
add_owner_approval/2 (InList, OutList) appends label('Owner-Approval', need(_)) to InList building OutList if no owners has given a Code-Review +2 to this path change.
This predicate is similar to the first one but generates a UserList with an hardcoded policy.
Since add_owner_approval/3 is not using hard coded policies, it can be suitable for complex customizations.
There is a second plugin, gerrit-owners-autoassign which depends on gerrit-owners. It will automatically assign all of the owners to review a change when it's created or updated.