commit | e17ec6c197576120747e5bc428b76926e0f3833d | [log] [tgz] |
---|---|---|
author | Hector Oswaldo Caballero <hector.caballero@ericsson.com> | Mon Dec 11 17:19:42 2017 -0500 |
committer | Hector Oswaldo Caballero <hector.caballero@ericsson.com> | Wed Dec 13 07:56:20 2017 -0500 |
tree | b9fc199131ab698c08a6d488c8a99fc835289c71 | |
parent | 125bd315e6717eec10f5fd6ddd7e5dd988bee3f9 [diff] |
Remove duplicated build dependencies External dependencies were specified twice: explicitly and in owner-common as transitive deps. Test plan: * Build plugins before and after this change and verify resulting jars are identical. * Run tests and verify they all succeed. * Deploy jars generated after this change and test plugins are loaded without errors in local site and plugin functionality is preserved. Change-Id: Iac5aa5a06b7ac38dc90a6c7d1bed8886cec132be
This plugin provides some Prolog predicates that can be used to add customized validation checks based on the approval of ‘path owners’ of a particular folder in the project.
That allows creating a single big project including multiple components and users have different roles depending on the particular path where changes are being proposed. A user can be “owner” in a specific directory, and thus influencing the approvals of changes there, but cannot do the same in others paths, so assuring a kind of dynamic subproject access rights.
There are currently two main prolog public verbs:
add_owner_approval/3
(UserList, InList, OutList) appends label('Owner-Approval', need(_))
to InList building OutList if UserList has no users contained in the defined owners of this path change.
In other words, the predicate just copies InList to OutList if at least one of the elements in UserList is an owner.
add_owner_approval/2
(InList, OutList) appends label('Owner-Approval', need(_))
to InList building OutList if no owners has given a Code-Review +2 to this path change.
This predicate is similar to the first one but generates a UserList with an hardcoded policy.
Since add_owner_approval/3 is not using hard coded policies, it can be suitable for complex customizations.
There is a second plugin, gerrit-owners-autoassign which depends on gerrit-owners. It will automatically assign all of the owners to review a change when it's created or updated.
Create three symbolic links of the owners-owners, owners-common and owners-autoassign from the Gerrit source code /plugins directory to the subdirectories of this project.
Then build the owners and owners-autoassign plugins with the usual Gerrit plugin compile command.
Example:
$ git clone https://gerrit.googlesource.com/plugins/owners $ git clone https://gerrit.googlesource.com/gerrit $ cd gerrit/plugins $ ln -s ../../owners/owners* . $ ln -sf ../../owners/external_plugin_deps.bzl . $ cd .. $ bazel test plugins/owners-common:test $ bazel build plugins/owners plugins/owners-autoassign
NOTE: the owners-common folder is producing shared artifacts for the two plugins and does not need to be built separately being a direct dependency of the build process. Its resulting .jar must not be installed in gerrit plugins directory.