| commit | 461866edca2ba8b532a55dde9d4915783646f7cd | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Wed May 17 08:39:55 2017 +0200 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Wed May 17 13:18:29 2017 +0000 |
| tree | f4bebb43c942631e3e54596155368ece293d2311 | |
| parent | 20b2a1b3d5d07abc00fc53bbee4c2b181656f433 [diff] |
Bazel: De-duplicate plugins API in final artifact The build implementation currently erroneously transitively depends on the plugin API. As a consequence, the size of final artifact is 50 MB. After fixing it, it turns out that the transitive dependency on prolog:common rule in Gerrit core pulls in another 45 MB dependency from Gerrit core. That is due to the fact, that prolog:common transitively depends on gerrit-server that transitively depends on the virtually the whole Gerrit build graph. Fix it by exposing the missing prolog rule in the plugin API, and cut off the prolog runtime dependency as well. Prolog runtime is already included in the Gerrit final artifact anyway. Change-Id: If9d249fb9bb2e67a6103159157fd7fc5d593d7cb
This plugin provides some Prolog predicates that can be used to add customized validation checks based on the approval of ‘path owners’ of a particular folder in the project.
That allows creating a single big project including multiple components and users have different roles depending on the particular path where changes are being proposed. A user can be “owner” in a specific directory, and thus influencing the approvals of changes there, but cannot do the same in others paths, so assuring a kind of dynamic subproject access rights.
There are currently two main prolog public verbs:
add_owner_approval/3 (UserList, InList, OutList) appends label('Owner-Approval', need(_)) to InList building OutList if UserList has no users contained in the defined owners of this path change.
In other words, the predicate just copies InList to OutList if at least one of the elements in UserList is an owner.
add_owner_approval/2 (InList, OutList) appends label('Owner-Approval', need(_)) to InList building OutList if no owners has given a Code-Review +2 to this path change.
This predicate is similar to the first one but generates a UserList with an hardcoded policy.
Since add_owner_approval/3 is not using hard coded policies, it can be suitable for complex customizations.
There is a second plugin, gerrit-owners-autoassign which depends on gerrit-owners. It will automatically assign all of the owners to review a change when it's created or updated.
Create three symbolic links of the owners-owners, owners-common and owners-autoassign from the Gerrit source code /plugins directory to the subdirectories of this project.
Then build the owners and owners-autoassign plugins with the usual Gerrit plugin compile command.
Example:
$ git clone https://gerrit.googlesource.com/plugins/owners $ git clone https://gerrit.googlesource.com/gerrit $ cd gerrit/plugins $ ln -s ../../owners/owners* . $ ln -sf ../../owners/external_plugin_deps.bzl . $ cd .. $ bazel test plugins/owners-common:test $ bazel build plugins/owners plugins/owners-autoassign
NOTE: the owners-common folder is producing shared artifacts for the two plugins and does not need to be built separately being a direct dependency of the build process. Its resulting .jar must not be installed in gerrit plugins directory.