commit 2c4b7b55b8d8d6a566968b0ce4bf9edafc26f8af
author David Ostrovsky <david@ostrovsky.org> Fri Jul 28 06:25:15 2017 +0200
committer David Ostrovsky <david@ostrovsky.org> Fri Jul 28 06:27:50 2017 +0200
tree 2ea6a0f26992f5bebd64aba8b5bfd63563c6bea9
parent 4a16d4c86b7b00a8a518c8aa45e01d590e5c1387

WORKSPACE: Reuse external plugins dependencies

Change-Id: I9eb4a08393a9ca06a1ea351724c6fbd118d69fca

WORKSPACE

diff --git a/WORKSPACE b/WORKSPACE
index 3245bc1..5dfb6bd 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -15,16 +15,5 @@
 
 gerrit_api()
 
-load("@com_googlesource_gerrit_bazlets//tools:maven_jar.bzl", "maven_jar")
-
-maven_jar(
-    name = "scribe",
-    artifact = "org.scribe:scribe:1.3.7",
-    sha1 = "583921bed46635d9f529ef5f14f7c9e83367bc6e",
-)
-
-maven_jar(
-    name = "commons_codec",
-    artifact = "commons-codec:commons-codec:1.4",
-    sha1 = "4216af16d38465bbab0f3dff8efa14204f7a399a",
-)
+load(":external_plugin_deps.bzl", "external_plugin_deps")
+external_plugin_deps(omit_commons_codec = False)

external_plugin_deps.bzl

diff --git a/external_plugin_deps.bzl b/external_plugin_deps.bzl
index d04c600..026221a 100644
--- a/external_plugin_deps.bzl
+++ b/external_plugin_deps.bzl
@@ -1,8 +1,15 @@
 load("//tools/bzl:maven_jar.bzl", "maven_jar")
 
-def external_plugin_deps():
+def external_plugin_deps(omit_commons_codec = True):
   maven_jar(
       name = "scribe",
       artifact = "org.scribe:scribe:1.3.7",
       sha1 = "583921bed46635d9f529ef5f14f7c9e83367bc6e",
-   )
+  )
+  if not omit_commons_codec:
+    maven_jar(
+       name = "commons_codec",
+       artifact = "commons-codec:commons-codec:1.4",
+       sha1 = "4216af16d38465bbab0f3dff8efa14204f7a399a",
+    )
+

tools/bzl/maven_jar.bzl

diff --git a/tools/bzl/maven_jar.bzl b/tools/bzl/maven_jar.bzl
new file mode 100644
index 0000000..2eabedb
--- /dev/null
+++ b/tools/bzl/maven_jar.bzl
@@ -0,0 +1 @@
+load("@com_googlesource_gerrit_bazlets//tools:maven_jar.bzl", "maven_jar")