Remove unnecessary test
BatchRefUpdateValidatorTest.
compareAndPutShouldSucceedIfTheObjectionHasNotTheExpectedValueWithDesiredEnforcement
test is not testing expected behaviour. compareAndPut should not succeed
if object has not the expected value unless EnforcePolicy.IGNORED is
set. This test is not covering EnforcePolicy.IGNORED use case. It is
passing because during the test setup expected value in set in
zookeeper.
Change-Id: Ib9b95085ae6cb3c6d0450ca3ba73e0045115174a
diff --git a/src/test/java/com/googlesource/gerrit/plugins/multisite/validation/BatchRefUpdateValidatorTest.java b/src/test/java/com/googlesource/gerrit/plugins/multisite/validation/BatchRefUpdateValidatorTest.java
index 5c18e4f..5a68d2f 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/multisite/validation/BatchRefUpdateValidatorTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/multisite/validation/BatchRefUpdateValidatorTest.java
@@ -14,7 +14,6 @@
package com.googlesource.gerrit.plugins.multisite.validation;
-import static com.google.common.truth.Truth.assertThat;
import static junit.framework.TestCase.assertFalse;
import static org.eclipse.jgit.transport.ReceiveCommand.Type.UPDATE;
@@ -36,7 +35,6 @@
import org.eclipse.jgit.junit.TestRepository;
import org.eclipse.jgit.lib.BatchRefUpdate;
import org.eclipse.jgit.lib.NullProgressMonitor;
-import org.eclipse.jgit.lib.Ref;
import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.revwalk.RevCommit;
import org.eclipse.jgit.revwalk.RevWalk;
@@ -108,26 +106,6 @@
}
@Test
- public void compareAndPutShouldSucceedIfTheObjectionHasNotTheExpectedValueWithDesiredEnforcement()
- throws Exception {
- String projectName = "All-Users";
- String externalIds = "refs/meta/external-ids";
-
- List<ReceiveCommand> cmds = Arrays.asList(new ReceiveCommand(A, B, externalIds, UPDATE));
-
- BatchRefUpdate batchRefUpdate = newBatchUpdate(cmds);
- BatchRefUpdateValidator batchRefUpdateValidator = newDefaultValidator(projectName);
-
- Ref zkExistingRef = SharedRefDatabase.newRef(externalIds, B.getId());
- zookeeperContainer.createRefInZk(projectName, zkExistingRef);
-
- batchRefUpdateValidator.executeBatchUpdateWithValidation(
- batchRefUpdate, () -> execute(batchRefUpdate));
-
- assertThat(zookeeperContainer.readRefValueFromZk(projectName, zkExistingRef)).isEqualTo(B);
- }
-
- @Test
public void compareAndPutShouldAlwaysIngoreAlwaysDraftCommentsEvenOutOfOrder() throws Exception {
String DRAFT_COMMENT = "refs/draft-comments/56/450756/1013728";
List<ReceiveCommand> cmds = Arrays.asList(new ReceiveCommand(A, B, DRAFT_COMMENT, UPDATE));
