commit b5e27d6ca33124344535f02d58ab7c73109e48cf
author David Ostrovsky <david@ostrovsky.org> Sat May 25 18:25:56 2019 +0200
committer Luca Milanesio <luca.milanesio@gmail.com> Mon Aug 19 07:31:44 2019 +0000
tree 35f0583ad5a38db79016ad5a035ca24ac53ad8ef
parent 7169455597d29cc2ce8b307c78c17056d8163710

ForwardedIndexChangeHandler: Suppress FutureReturnValueIgnored warning

When all error prone warnings are enabled the FutureReturnValueIgnored
bug pattern is reported:

ForwardedIndexChangeHandler.java:130: error: [FutureReturnValueIgnored]\
Return value of methods returning Future must be checked. Ignoring \
returned Futures suppresses exceptions thrown from the code that \
completes the Future.
    indexExecutor.schedule(
                          ^
    (see https://errorprone.info/bugpattern/FutureReturnValueIgnored)

Change-Id: I855d3d10fe5fd52f45f493561f8cd603567cc516

src/main/java/com/googlesource/gerrit/plugins/multisite/forwarder/ForwardedIndexChangeHandler.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/multisite/forwarder/ForwardedIndexChangeHandler.java b/src/main/java/com/googlesource/gerrit/plugins/multisite/forwarder/ForwardedIndexChangeHandler.java
index 4b0a142..1913b00 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/multisite/forwarder/ForwardedIndexChangeHandler.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/multisite/forwarder/ForwardedIndexChangeHandler.java
@@ -32,6 +32,7 @@
 import com.googlesource.gerrit.plugins.multisite.index.ForwardedIndexExecutor;
 import java.io.IOException;
 import java.util.Optional;
+import java.util.concurrent.Future;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.TimeUnit;
 
@@ -154,17 +155,19 @@
         retryCount,
         id,
         retryInterval);
-    indexExecutor.schedule(
-        () -> {
-          try (ManualRequestContext ctx = oneOffCtx.open()) {
-            Context.setForwardedEvent(true);
-            doIndex(id, indexEvent, retryCount);
-          } catch (Exception e) {
-            log.warn("Change {} could not be indexed", id, e);
-          }
-        },
-        retryInterval,
-        TimeUnit.MILLISECONDS);
+    @SuppressWarnings("unused")
+    Future<?> possiblyIgnoredError =
+        indexExecutor.schedule(
+            () -> {
+              try (ManualRequestContext ctx = oneOffCtx.open()) {
+                Context.setForwardedEvent(true);
+                doIndex(id, indexEvent, retryCount);
+              } catch (Exception e) {
+                log.warn("Change {} could not be indexed", id, e);
+              }
+            },
+            retryInterval,
+            TimeUnit.MILLISECONDS);
     return true;
   }