Fix replication lag unit: seconds
Change-Id: I69282ea6b94f65fe493ccdf3d95575bbbe5eee41
diff --git a/src/main/java/com/googlesource/gerrit/plugins/multisite/consumer/SubscriberMetrics.java b/src/main/java/com/googlesource/gerrit/plugins/multisite/consumer/SubscriberMetrics.java
index f112f07..f1f095c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/multisite/consumer/SubscriberMetrics.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/multisite/consumer/SubscriberMetrics.java
@@ -26,7 +26,6 @@
import com.googlesource.gerrit.plugins.multisite.validation.ProjectVersionRefUpdate;
import com.googlesource.gerrit.plugins.replication.RefReplicatedEvent;
import com.googlesource.gerrit.plugins.replication.RefReplicationDoneEvent;
-
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
@@ -39,8 +38,8 @@
private static final String SUBSCRIBER_SUCCESS_COUNTER = "subscriber_msg_consumer_counter";
private static final String SUBSCRIBER_FAILURE_COUNTER =
"subscriber_msg_consumer_failure_counter";
- private static final String REPLICATION_LAG_MS =
- "multi_site/subscriber/subscriber_replication_status/ms_behind";
+ private static final String REPLICATION_LAG_SEC =
+ "multi_site/subscriber/subscriber_replication_status/sec_behind";
private final Counter1<String> subscriberSuccessCounter;
private final Counter1<String> subscriberFailureCounter;
@@ -70,9 +69,9 @@
Field.ofString(
SUBSCRIBER_FAILURE_COUNTER, "Subscriber failed to consume messages count"));
metricMaker.newCallbackMetric(
- REPLICATION_LAG_MS,
+ REPLICATION_LAG_SEC,
Long.class,
- new Description("Replication lag (ms)").setGauge().setUnit(Description.Units.MILLISECONDS),
+ new Description("Replication lag (sec)").setGauge().setUnit(Description.Units.SECONDS),
() -> {
Collection<Long> lags = replicationStatusPerProject.values();
if (lags.isEmpty()) {
diff --git a/src/main/resources/Documentation/about.md b/src/main/resources/Documentation/about.md
index 5ac3dec..b6de0a9 100644
--- a/src/main/resources/Documentation/about.md
+++ b/src/main/resources/Documentation/about.md
@@ -93,6 +93,6 @@
`metric=plugins/multi-site/multi_site/subscriber/subscriber_message_consumer_failure_counter/subscriber_msg_consumer_poll_failure_counter, type=com.codahale.metrics.Meter`
-* Subscriber replication status (ms behind the producer)
+* Subscriber replication lag (sec behind the producer)
-`metric=site/multi_site/subscriber/subscriber_replication_status/ms_behind, type=com.google.gerrit.metrics.dropwizard.CallbackMetricImpl`
\ No newline at end of file
+`metric=site/multi_site/subscriber/subscriber_replication_status/sec_behind, type=com.google.gerrit.metrics.dropwizard.CallbackMetricImpl`
