| commit | 2d6dadf82b3df2e6fa10a146e5edaa6f270ed629 | [log] [tgz] |
|---|---|---|
| author | Marco Miller <marco.miller@ericsson.com> | Mon Sep 21 16:27:05 2020 -0400 |
| committer | Marco Miller <marco.mmiller@gmail.com> | Tue Sep 22 17:26:59 2020 +0000 |
| tree | 2e0fa259df57f8f2e1df34059d9448283a935f67 | |
| parent | 0f57de4e79917a85be1409bde60be68b3fd20bd9 [diff] |
e2e-tests: Remove unnecessary type specifications As these do not lend warnings in IntelliJ once removed. Indeed, one "should almost never annotate the type of a private field or a local variable, as their type will usually be immediately evident in their value" [1]. [1] https://docs.scala-lang.org/style/types.html#inference Change-Id: I1979352e0d31da44c1bb72e95491154176f7335c
diff --git a/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CloneUsingMultiGerrit1.scala b/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CloneUsingMultiGerrit1.scala index cc80577..14c1716 100644 --- a/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CloneUsingMultiGerrit1.scala +++ b/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CloneUsingMultiGerrit1.scala
@@ -23,7 +23,7 @@ class CloneUsingMultiGerrit1 extends GitSimulation { private val data: FeederBuilder = jsonFile(resource).convert(keys).queue - private var default: String = name + private var default = name def this(default: String) { this()
diff --git a/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CreateChangeUsingMultiGerrit.scala b/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CreateChangeUsingMultiGerrit.scala index 51dd72d..0011429 100644 --- a/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CreateChangeUsingMultiGerrit.scala +++ b/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CreateChangeUsingMultiGerrit.scala
@@ -24,7 +24,7 @@ class CreateChangeUsingMultiGerrit extends GerritSimulation { private val data: FeederBuilder = jsonFile(resource).convert(keys).queue - private val default: String = name + private val default = name private val numberKey = "_number" override def relativeRuntimeWeight = 10
diff --git a/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CreateProjectUsingMultiGerritTwice.scala b/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CreateProjectUsingMultiGerritTwice.scala index 5270ce0..3150405 100644 --- a/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CreateProjectUsingMultiGerritTwice.scala +++ b/src/test/scala/com/googlesource/gerrit/plugins/multisite/scenarios/CreateProjectUsingMultiGerritTwice.scala
@@ -20,7 +20,7 @@ import scala.concurrent.duration._ class CreateProjectUsingMultiGerritTwice extends GitSimulation { - private val default: String = name + private val default = name private val createProject = new CreateProjectUsingMultiGerrit(default) private val deleteProject = new DeleteProjectUsingMultiGerrit(default)