commit ae840e9babc0b63af6eb1c6afaf7e02cb61d1b3f
author David Pursehouse <dpursehouse@collab.net> Mon Feb 06 10:36:55 2017 +0900
committer David Pursehouse <dpursehouse@collab.net> Mon Feb 06 10:36:55 2017 +0900
tree 7b59780bc16c8b8fbf998ec62dd5e2aef101c695
parent 1285c778c73b290a93c603570b10d3e76ac55f3b

Extract config keys and defaults to constants

Change-Id: I0c7f8383807b2ef1d0fca0003ff6a220194f2b3f

src/main/java/com/googlesource/gerrit/plugins/metricsreporters/GerritGraphiteReporter.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/metricsreporters/GerritGraphiteReporter.java b/src/main/java/com/googlesource/gerrit/plugins/metricsreporters/GerritGraphiteReporter.java
index 0c17cbb..4849d49 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/metricsreporters/GerritGraphiteReporter.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/metricsreporters/GerritGraphiteReporter.java
@@ -43,6 +43,13 @@
   private static final Logger log =
       LoggerFactory.getLogger(GerritGraphiteReporter.class);
 
+  private static final String SECTION_GRAPHITE = "graphite";
+  private static final String KEY_HOST = "host";
+  private static final String KEY_PORT = "port";
+  private static final String KEY_PREFIX = "prefix";
+  private static final String DEFAULT_HOST = "localhost";
+  private static final int DEFAULT_PORT = 2003;
+  private static final String DEFAULT_PREFIX = "gerrit";
   private final GraphiteReporter graphiteReporter;
 
   @Inject
@@ -52,12 +59,12 @@
       MetricRegistry registry) {
     Config config = configFactory.getGlobalPluginConfig(pluginName);
     String host = firstNonNull(
-        config.getString("graphite", null, "host"), "localhost");
-    int port = config.getInt("graphite", "port", 2003);
-    String prefix = config.getString("graphite", null, "prefix");
+        config.getString(SECTION_GRAPHITE, null, KEY_HOST), DEFAULT_HOST);
+    int port = config.getInt(SECTION_GRAPHITE, KEY_PORT, DEFAULT_PORT);
+    String prefix = config.getString(SECTION_GRAPHITE, null, KEY_PREFIX);
     if (prefix == null) {
       try {
-        prefix = name("gerrit", InetAddress.getLocalHost().getHostName());
+        prefix = name(DEFAULT_PREFIX, InetAddress.getLocalHost().getHostName());
       } catch (UnknownHostException e) {
         log.error("Failed to get hostname", e);
         throw new RuntimeException(e);