LfsSshAuth: Check number of arguments to git-lfs-authenticate command
If the command is called with the wrong number of arguments, i.e. less
than 2, an IndexOutOfBoundsException occurs when attempting to extract
the project and command values from the args array. This then results
in an "internal server error" message being reported to the client.
Add a check, and return a sane error message if the number of arguments
is not as expected.
Change-Id: If44f878fbee1d44ff901ac092d96a9bc5ad04da8
diff --git a/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsSshAuth.java b/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsSshAuth.java
index 61a6032..08d7ca7 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsSshAuth.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsSshAuth.java
@@ -48,6 +48,9 @@
@Override
public String authenticate(CurrentUser user, List<String> args) throws UnloggedFailure, Failure {
+ if (args.size() != 2) {
+ throw new UnloggedFailure(1, "Unexpected number of arguments");
+ }
try {
URL url = new URL(canonicalWebUrl);
String path = url.getPath();
