Remove usage of AuthConfig.isGitBasicAuth
Since change I26f5bcd78 the default HTTP auth is basic, and
the isGitBasicAuth method was removed.
Change-Id: Ide88e63fe8b42863360431095f272b0da608b9de
diff --git a/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsAuthUserProvider.java b/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsAuthUserProvider.java
index d1b3207..efac3af 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsAuthUserProvider.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsAuthUserProvider.java
@@ -23,7 +23,6 @@
import com.google.gerrit.server.IdentifiedUser;
import com.google.gerrit.server.account.AccountCache;
import com.google.gerrit.server.account.AccountState;
-import com.google.gerrit.server.config.AuthConfig;
import com.google.inject.Inject;
import com.google.inject.Provider;
import com.google.inject.Singleton;
@@ -34,7 +33,6 @@
private final Provider<AnonymousUser> anonymous;
private final Provider<CurrentUser> user;
- private final AuthConfig authCfg;
private final LfsSshRequestAuthorizer sshAuth;
private final AccountCache accounts;
private final IdentifiedUser.GenericFactory userFactory;
@@ -42,13 +40,11 @@
@Inject
LfsAuthUserProvider(Provider<AnonymousUser> anonymous,
Provider<CurrentUser> user,
- AuthConfig authCfg,
LfsSshRequestAuthorizer sshAuth,
AccountCache accounts,
IdentifiedUser.GenericFactory userFactory) {
this.anonymous = anonymous;
this.user = user;
- this.authCfg = authCfg;
this.sshAuth = sshAuth;
this.accounts = accounts;
this.userFactory = userFactory;
@@ -56,7 +52,7 @@
CurrentUser getUser(String auth, String project, String operation) {
if (!Strings.isNullOrEmpty(auth)) {
- if (auth.startsWith(BASIC_AUTH_PREFIX) && authCfg.isGitBasicAuth()) {
+ if (auth.startsWith(BASIC_AUTH_PREFIX)) {
return user.get();
}
diff --git a/src/main/resources/Documentation/config.md b/src/main/resources/Documentation/config.md
index d0b57b8..53bad5a 100644
--- a/src/main/resources/Documentation/config.md
+++ b/src/main/resources/Documentation/config.md
@@ -9,14 +9,6 @@
lfs.plugin = @PLUGIN@
: With this option set LFS requests are forwarded to the @PLUGIN@ plugin.
-### Section `auth`
-
-auth.gitBasicAuth = true
-: Git LFS client uses Basic HTTP auth with LFS requests. When this option
-is not enabled (not set or equals to `false`) Git LFS HTTP requests are treated
-as anonymous requests. Therefore requests will be successfully authorized only
-for projects that allows anonymous to perform requested operation.
-
## Per Project Settings
The following options can be configured in `@PLUGIN@.config` on the
