Fix formatting for posting web links Web links were posted in incorrect markdown format, it was like this [http://localhost:8080/4|Fix bug 1] This change fixex it to this: [fix bug 1](http://localhost:8080/4) Change-Id: I023e2e79b5b53ca97c1a60ade37f4d8cdd01e5a5
diff --git a/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardItsFacade.java b/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardItsFacade.java index 7bb677a..9f52be6 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardItsFacade.java +++ b/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardItsFacade.java
@@ -102,11 +102,9 @@ @Override public String createLinkForWebui(String url, String text) { - String ret = "[" + url; if (text != null && !text.isEmpty() && !text.equals(url)) { - ret += "|" + text; + return "[" + text + "]" + "(" + url + ")"; } - ret += "]"; - return ret; + return url; } }
diff --git a/src/test/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardItsFacadeTest.java b/src/test/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardItsFacadeTest.java index a2f687f..9364ad3 100644 --- a/src/test/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardItsFacadeTest.java +++ b/src/test/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardItsFacadeTest.java
@@ -37,7 +37,7 @@ StoryboardItsFacade itsFacade = createStoryboardItsFacade(); String actual = itsFacade.createLinkForWebui("Test-Url", "Test-Text"); - assertEquals("[Test-Url|Test-Text]", actual); + assertEquals("[Test-Text](Test-Url)", actual); } public void testCreateLinkForWebUiSameUrlAndText() { @@ -48,7 +48,7 @@ StoryboardItsFacade itsFacade = createStoryboardItsFacade(); String actual = itsFacade.createLinkForWebui("Test-Url", "Test-Url"); - assertEquals("[Test-Url]", actual); + assertEquals("Test-Url", actual); } public void testCreateLinkForWebUiNullText() { @@ -59,7 +59,7 @@ StoryboardItsFacade itsFacade = createStoryboardItsFacade(); String actual = itsFacade.createLinkForWebui("Test-Url", null); - assertEquals("[Test-Url]", actual); + assertEquals("Test-Url", actual); } public void testCreateLinkForWebUiEmptyText() { @@ -70,7 +70,7 @@ StoryboardItsFacade itsFacade = createStoryboardItsFacade(); String actual = itsFacade.createLinkForWebui("Test-Url", ""); - assertEquals("[Test-Url]", actual); + assertEquals("Test-Url", actual); } private StoryboardItsFacade createStoryboardItsFacade() { @@ -103,4 +103,4 @@ .toInstance("its-storyboard"); } } -} \ No newline at end of file +}