Fix its-rtc creating a fresh facade for each request
So far, a new RTCFacade was created every time a request was done. That
led to the creation of unnecessary objects and to the log being flooded
with connection messages.
Bind RTCFacade as a singleton and change the log level back to INFO.
Bug: Issue 3575
Change-Id: I5e7e717915d7fc09b2926b21ff706a6a31b41710
diff --git a/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCItsFacade.java b/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCItsFacade.java
index 24b8d69..e8526a1 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCItsFacade.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCItsFacade.java
@@ -55,7 +55,7 @@
this.injector = injector;
this.gerritConfig = gerritConfig;
client().ping();
- log.debug("Connected to RTC at " + getRtcUrl() + " as admin user "
+ log.info("Connected to RTC at " + getRtcUrl() + " as admin user "
+ getRtcUser());
} catch (Exception ex) {
log.warn("RTC is currently not available", ex);
diff --git a/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCModule.java b/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCModule.java
index 92e3789..9d3d79c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCModule.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCModule.java
@@ -26,6 +26,7 @@
import com.google.gerrit.server.config.ProjectConfigEntry;
import com.google.inject.AbstractModule;
import com.google.inject.Inject;
+import com.google.inject.Scopes;
import com.googlesource.gerrit.plugins.its.base.ItsHookModule;
import com.googlesource.gerrit.plugins.its.base.its.ItsFacade;
@@ -51,7 +52,7 @@
protected void configure() {
if (isConfigPresent(pluginName)) {
LOG.info("RTC is configured as ITS");
- bind(ItsFacade.class).to(RTCItsFacade.class);
+ bind(ItsFacade.class).to(RTCItsFacade.class).in(Scopes.SINGLETON);
bind(ProjectConfigEntry.class)
.annotatedWith(Exports.named("enabled"))
