Fix plugin not loading because of duplicated binding
Loading the plugin failed with a Guice exception [1] given that the same
binding was already defined by its-base and it was being loaded when
invoking the its-base module from its-rtc.
Remove duplicate binding from its-rtc.
[1] http://pastebin.com/a4JtTdZe
Change-Id: Ib4b9fac935f6e8ca1d7d75e1a990206958c6f096
diff --git a/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCModule.java b/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCModule.java
index 9d3d79c..8d83bc7 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCModule.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/its/rtc/RTCModule.java
@@ -19,18 +19,15 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import com.google.gerrit.extensions.annotations.Exports;
import com.google.gerrit.extensions.annotations.PluginName;
import com.google.gerrit.server.config.GerritServerConfig;
import com.google.gerrit.server.config.PluginConfigFactory;
-import com.google.gerrit.server.config.ProjectConfigEntry;
import com.google.inject.AbstractModule;
import com.google.inject.Inject;
import com.google.inject.Scopes;
import com.googlesource.gerrit.plugins.its.base.ItsHookModule;
import com.googlesource.gerrit.plugins.its.base.its.ItsFacade;
-import com.googlesource.gerrit.plugins.its.base.its.ItsHookEnabledConfigEntry;
public class RTCModule extends AbstractModule {
@@ -54,11 +51,6 @@
LOG.info("RTC is configured as ITS");
bind(ItsFacade.class).to(RTCItsFacade.class).in(Scopes.SINGLETON);
- bind(ProjectConfigEntry.class)
- .annotatedWith(Exports.named("enabled"))
- .toInstance(new ItsHookEnabledConfigEntry(
- pluginName, pluginCfgFactory));
-
install(new ItsHookModule(pluginName, pluginCfgFactory));
}
}