Remove plugin name from build configuration Removing the pluginName from the build configuration allows the Gerrit plugin loader to dynamically set the plugin name to the same as the file name (minus the extension). This makes it a little more flexible for the end user. In cases where the end users wants to change the plugin name they only need to rename the plugin file instead of having to rebuild the plugin. This is a follow on to change Ib685a802 which documents a use case for changing an its plugin file name. Change-Id: Id79285ebe3f350a86dead7f1b2e4b96aa3b27130
diff --git a/BUCK b/BUCK index 9a3e8dc..b866bf6 100644 --- a/BUCK +++ b/BUCK
@@ -3,11 +3,10 @@ srcs = glob(['src/main/java/**/*.java']), resources = glob(['src/main/resources/**/*']), manifest_entries = [ - 'Gerrit-PluginName: its-bugzilla', 'Gerrit-Module: com.googlesource.gerrit.plugins.hooks.bz.BugzillaModule', 'Gerrit-InitStep: com.googlesource.gerrit.plugins.hooks.bz.InitBugzilla', 'Gerrit-ReloadMode: reload', - 'Implementation-Title: Plugin its-bugzilla', + 'Implementation-Title: Bugzilla ITS Plugin', 'Implementation-URL: https://www.wikimediafoundation.org', ], deps = [
diff --git a/pom.xml b/pom.xml index 50f3652..ec6b631 100644 --- a/pom.xml +++ b/pom.xml
@@ -29,7 +29,6 @@ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <Gerrit-ApiType>plugin</Gerrit-ApiType> <Gerrit-ReloadMode>reload</Gerrit-ReloadMode> - <Gerrit-PluginName>its-bugzilla</Gerrit-PluginName> <Gerrit-InitStep>com.googlesource.gerrit.plugins.hooks.bz.InitBugzilla</Gerrit-InitStep> <Gerrit-Module>com.googlesource.gerrit.plugins.hooks.bz.BugzillaModule</Gerrit-Module> <easymockVersion>3.0</easymockVersion> @@ -70,12 +69,11 @@ <manifestEntries> <Implementation-Vendor>Wikimedia Foundation, Inc.</Implementation-Vendor> <Implementation-URL>https://www.wikimediafoundation.org/</Implementation-URL> - <Implementation-Title>Plugin ${project.artifactId}</Implementation-Title> + <Implementation-Title>Bugzilla ITS Plugin</Implementation-Title> <Implementation-Version>${project.version}</Implementation-Version> <Gerrit-ApiType>${Gerrit-ApiType}</Gerrit-ApiType> <Gerrit-ApiVersion>${project.version}</Gerrit-ApiVersion> <Gerrit-ReloadMode>${Gerrit-ReloadMode}</Gerrit-ReloadMode> - <Gerrit-PluginName>${Gerrit-PluginName}</Gerrit-PluginName> <Gerrit-InitStep>${Gerrit-InitStep}</Gerrit-InitStep> <Gerrit-Module>${Gerrit-Module}</Gerrit-Module> </manifestEntries>