commit 9e0779828d4b9f1aa37a7acf2c9c75ed3cfded09
author Luca Milanesio <luca.milanesio@gmail.com> Wed Sep 28 18:19:19 2016 +0100
committer Luca Milanesio <luca.milanesio@gmail.com> Wed Sep 28 18:19:19 2016 +0100
tree 6dcb7471fd910d7cec559031938e8aa42e698687
parent e38e0b5e752271071ed9284cca3d795467ad09d5

its-* is enabled only if enabled flag is not false

We need to enable ITS integration for any condition different
than 'false' (enforced and true are valid values)

Change-Id: I86689fc803f62cce54201a720c80d0f6267fd4b2

src/main/java/com/googlesource/gerrit/plugins/its/base/its/ItsConfig.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/its/base/its/ItsConfig.java b/src/main/java/com/googlesource/gerrit/plugins/its/base/its/ItsConfig.java
index 46fc817..581ef99 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/its/base/its/ItsConfig.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/its/base/its/ItsConfig.java
@@ -100,14 +100,14 @@
     for (ProjectState parentState : projectState.treeInOrder()) {
       PluginConfig parentCfg =
           pluginCfgFactory.getFromProjectConfig(parentState, pluginName);
-      if ("enforced".equals(parentCfg.getString("enabled"))
+      if (!"false".equals(parentCfg.getString("enabled"))
           && isEnabledForBranch(parentState, refName)) {
         return true;
       }
     }
 
-    return pluginCfgFactory.getFromProjectConfigWithInheritance(
-        projectState, pluginName).getBoolean("enabled", false)
+    return !"false".equals(pluginCfgFactory.getFromProjectConfigWithInheritance(
+        projectState, pluginName).getString("enabled", "false"))
         && isEnabledForBranch(projectState, refName);
   }