Use try with resources for buffered writers and file writers With the latest Eclipse settings, a warning was shown when objects that implement Autoclosable interface are not handled within a try-with-resources statement. Use try-with-resources for BufferedWriters and FileWriters. Change-Id: Icea1da6984857d177e1e296c4dfabe450b570b9c
diff --git a/src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleBaseTest.java b/src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleBaseTest.java index c965349..596afc7 100644 --- a/src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleBaseTest.java +++ b/src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleBaseTest.java
@@ -378,11 +378,10 @@ assertTrue("Failed to create parent (" + ruleBaseParentFile + ") for " + "rule base", ruleBaseParentFile.mkdirs()); } - FileWriter unbufferedWriter = new FileWriter(ruleBaseFile); - BufferedWriter writer = new BufferedWriter(unbufferedWriter); - writer.write(rules); - writer.close(); - unbufferedWriter.close(); + try (FileWriter unbufferedWriter = new FileWriter(ruleBaseFile); + BufferedWriter writer = new BufferedWriter(unbufferedWriter)) { + writer.write(rules); + } } @Override
diff --git a/src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/action/AddVelocityCommentTest.java b/src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/action/AddVelocityCommentTest.java index b24c13f..5a33db6 100644 --- a/src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/action/AddVelocityCommentTest.java +++ b/src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/action/AddVelocityCommentTest.java
@@ -360,11 +360,10 @@ "rule base", templateParentFile.mkdirs()); File templateFile = new File(templateParentFile, "test-template.vm"); - FileWriter unbufferedWriter = new FileWriter(templateFile); - BufferedWriter writer = new BufferedWriter(unbufferedWriter); - writer.write(template); - writer.close(); - unbufferedWriter.close(); + try (FileWriter unbufferedWriter = new FileWriter(templateFile); + BufferedWriter writer = new BufferedWriter(unbufferedWriter)) { + writer.write(template); + } } @Override