Merge branch 'stable-2.12'
* stable-2.12:
Fix Eclipse project generation
Add 'eclipse-out' to the list of ignored folders
Change-Id: I74396e567223e8fb28e26caa74ea97b002a1423c
diff --git a/BUCK b/BUCK
index 28e335b..e08dc76 100644
--- a/BUCK
+++ b/BUCK
@@ -2,10 +2,9 @@
MODULE = 'com.googlesource.gerrit.plugins.importer.Importer'
-if STANDALONE_MODE:
- HTTP_LIB = '//lib/http:http_lib'
-else:
- HTTP_LIB = '//plugins/importer/lib/http:http_lib'
+PROVIDED_DEPS = [
+ '//lib:gson',
+]
gerrit_plugin(
name = 'importer',
@@ -20,13 +19,7 @@
'Gerrit-SshModule: com.googlesource.gerrit.plugins.importer.SshModule',
'Gerrit-HttpModule: com.googlesource.gerrit.plugins.importer.HttpModule',
],
- deps = [
- HTTP_LIB,
- ],
- provided_deps = [
- '//lib:gson',
- '//lib/log:log4j',
- ],
+ provided_deps = PROVIDED_DEPS + GERRIT_TESTS,
)
# this is required for bucklets/tools/eclipse/project.py to work
@@ -37,4 +30,3 @@
'//lib/gwt:user',
],
)
-
diff --git a/lib/commons/BUCK b/lib/commons/BUCK
deleted file mode 100644
index ba42a1f..0000000
--- a/lib/commons/BUCK
+++ /dev/null
@@ -1,41 +0,0 @@
-include_defs('//bucklets/maven_jar.bucklet')
-
-java_library(
- name = 'commons_lib',
- deps = [
- ':codec',
- ':io',
- ':lang',
- ],
- visibility = ['PUBLIC'],
-)
-
-EXCLUDE = [
- 'META-INF/LICENSE.txt',
- 'META-INF/NOTICE.txt'
-]
-
-maven_jar(
- name = 'codec',
- id = 'commons-codec:commons-codec:1.4',
- sha1 = '4216af16d38465bbab0f3dff8efa14204f7a399a',
- license = 'Apache2.0',
- exclude = EXCLUDE,
-)
-
-maven_jar(
- name = 'io',
- id = 'commons-io:commons-io:1.4',
- sha1 = 'a8762d07e76cfde2395257a5da47ba7c1dbd3dce',
- license = 'Apache2.0',
- exclude = EXCLUDE,
-)
-
-maven_jar(
- name = 'lang',
- id = 'commons-lang:commons-lang:2.5',
- sha1 = 'b0236b252e86419eef20c31a44579d2aee2f0a69',
- license = 'Apache2.0',
- exclude = EXCLUDE,
-)
-
diff --git a/lib/gerrit/BUCK b/lib/gerrit/BUCK
index f1ab768..6bcc623 100644
--- a/lib/gerrit/BUCK
+++ b/lib/gerrit/BUCK
@@ -1,12 +1,11 @@
include_defs('//bucklets/maven_jar.bucklet')
-VER = '2.12'
-REPO = MAVEN_CENTRAL
+VER = '2.13-SNAPSHOT'
+REPO = MAVEN_LOCAL
maven_jar(
name = 'plugin-api',
id = 'com.google.gerrit:gerrit-plugin-api:' + VER,
- sha1 = '8ce1f6e65078bbcf03a1758f96b3ebca19b7fe3c',
attach_source = False,
repository = REPO,
license = 'Apache2.0',
@@ -15,8 +14,15 @@
maven_jar(
name = 'gwtui-api',
id = 'com.google.gerrit:gerrit-plugin-gwtui:' + VER,
- sha1 = 'a7e7d82746b847678022242ec9eb44d1f16e8639',
attach_source = False,
repository = REPO,
license = 'Apache2.0',
)
+
+maven_jar(
+ name = 'acceptance-framework',
+ id = 'com.google.gerrit:gerrit-acceptance-framework:' + VER,
+ license = 'Apache2.0',
+ attach_source = False,
+ repository = REPO,
+)
diff --git a/lib/http/BUCK b/lib/http/BUCK
deleted file mode 100644
index 4de1df9..0000000
--- a/lib/http/BUCK
+++ /dev/null
@@ -1,40 +0,0 @@
-include_defs('//bucklets/gerrit_plugin.bucklet')
-include_defs('//bucklets/maven_jar.bucklet')
-
-if STANDALONE_MODE:
- COMMONS = '//lib/commons:commons_lib'
- LOG = '//lib/log:jcl-over-slf4j'
-else:
- COMMONS = '//plugins/importer/lib/commons:commons_lib'
- LOG = '//plugins/importer/lib/log:jcl-over-slf4j'
-
-java_library(
- name = 'http_lib',
- exported_deps = [
- ':httpclient',
- ':httpcore',
- ],
- visibility = ['PUBLIC'],
-)
-
-maven_jar(
- name = 'httpclient',
- id = 'org.apache.httpcomponents:httpclient:4.3.4',
- bin_sha1 = 'a9a1fef2faefed639ee0d0fba5b3b8e4eb2ff2d8',
- src_sha1 = '7a14aafed8c5e2c4e360a2c1abd1602efa768b1f',
- license = 'Apache2.0',
- deps = [
- COMMONS,
- ':httpcore',
- LOG,
- ],
-)
-
-maven_jar(
- name = 'httpcore',
- id = 'org.apache.httpcomponents:httpcore:4.3.2',
- bin_sha1 = '31fbbff1ddbf98f3aa7377c94d33b0447c646b6e',
- src_sha1 = '4809f38359edeea9487f747e09aa58ec8d3a54c5',
- license = 'Apache2.0',
-)
-
diff --git a/lib/log/BUCK b/lib/log/BUCK
deleted file mode 100644
index 17e606b..0000000
--- a/lib/log/BUCK
+++ /dev/null
@@ -1,16 +0,0 @@
-include_defs('//bucklets/maven_jar.bucklet')
-
-maven_jar(
- name = 'jcl-over-slf4j',
- id = 'org.slf4j:jcl-over-slf4j:1.7.7',
- sha1 = '56003dcd0a31deea6391b9e2ef2f2dc90b205a92',
- license = 'slf4j',
-)
-
-maven_jar(
- name = 'log4j',
- id = 'log4j:log4j:1.2.17',
- sha1 = '5af35056b4d257e4b64b9e8069c0746e8b08629f',
- license = 'Apache2.0',
- exclude = ['META-INF/LICENSE', 'META-INF/NOTICE'],
-)
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/AccountUtil.java b/src/main/java/com/googlesource/gerrit/plugins/importer/AccountUtil.java
index 90147a0..989410a 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/AccountUtil.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/AccountUtil.java
@@ -92,6 +92,13 @@
case CLIENT_SSL_CERT_LDAP:
case LDAP:
return createAccountByLdapAndAddSshKeys(api, acc);
+ case CUSTOM_EXTENSION:
+ case DEVELOPMENT_BECOME_ANY_ACCOUNT:
+ case HTTP:
+ case LDAP_BIND:
+ case OAUTH:
+ case OPENID:
+ case OPENID_SSO:
default:
return createLocalUser(acc);
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/AddApprovalsStep.java b/src/main/java/com/googlesource/gerrit/plugins/importer/AddApprovalsStep.java
index 4477031..31d6014 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/AddApprovalsStep.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/AddApprovalsStep.java
@@ -130,7 +130,11 @@
private ChangeControl control(Change change, Account.Id id)
throws NoSuchChangeException {
- return changeControlFactory.controlFor(change,
- genericUserFactory.create(id));
+ try {
+ return changeControlFactory.controlFor(db, change,
+ genericUserFactory.create(id));
+ } catch (OrmException e) {
+ throw new NoSuchChangeException(change.getId());
+ }
}
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/AddHashtagsStep.java b/src/main/java/com/googlesource/gerrit/plugins/importer/AddHashtagsStep.java
index a8de4a2..3e8de69 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/AddHashtagsStep.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/AddHashtagsStep.java
@@ -77,7 +77,8 @@
void add() throws IllegalArgumentException, OrmException,
NoSuchChangeException, UpdateException, RestApiException {
- ChangeControl ctrl = changeControlFactory.controlFor(change, currentUser);
+ ChangeControl ctrl =
+ changeControlFactory.controlFor(db.get(), change, currentUser);
try {
if (resume) {
@@ -108,4 +109,4 @@
ChangeTriplet.format(change), currentUser.getUserName()));
}
}
-}
\ No newline at end of file
+}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/CompleteProjectImport.java b/src/main/java/com/googlesource/gerrit/plugins/importer/CompleteProjectImport.java
index c108e08..2a6438d 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/CompleteProjectImport.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/CompleteProjectImport.java
@@ -38,7 +38,6 @@
import org.eclipse.jgit.lib.Ref;
import org.eclipse.jgit.lib.RefUpdate;
import org.eclipse.jgit.lib.Repository;
-import org.eclipse.jgit.util.FS;
import java.io.File;
import java.io.IOException;
@@ -77,7 +76,7 @@
private LockFile lockForDelete(Project.NameKey project)
throws ResourceConflictException {
File importStatus = projects.FS_LAYOUT.getImportStatusFile(project.get());
- LockFile lockFile = new LockFile(importStatus, FS.DETECTED);
+ LockFile lockFile = new LockFile(importStatus);
try {
if (lockFile.lock()) {
return lockFile;
@@ -105,6 +104,12 @@
case FAST_FORWARD:
case FORCED:
break;
+ case IO_FAILURE:
+ case LOCK_FAILURE:
+ case NOT_ATTEMPTED:
+ case REJECTED:
+ case REJECTED_CURRENT_BRANCH:
+ case RENAMED:
default:
throw new IOException(String.format(
"Failed to delete %s, RefUpdate.Result = %s", ref, result));
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/ConfigureRepositoryStep.java b/src/main/java/com/googlesource/gerrit/plugins/importer/ConfigureRepositoryStep.java
index f15a3ec..aca47c3 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/ConfigureRepositoryStep.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/ConfigureRepositoryStep.java
@@ -27,10 +27,8 @@
import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.lib.StoredConfig;
-import java.nio.file.Files;
-import java.nio.file.Path;
-
import java.io.IOException;
+import java.nio.file.Path;
@Singleton
class ConfigureRepositoryStep {
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/GitFetchStep.java b/src/main/java/com/googlesource/gerrit/plugins/importer/GitFetchStep.java
index 2fc0f59..132a36c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/GitFetchStep.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/GitFetchStep.java
@@ -77,6 +77,12 @@
case FORCED:
case NO_CHANGE:
break;
+ case IO_FAILURE:
+ case LOCK_FAILURE:
+ case NOT_ATTEMPTED:
+ case REJECTED:
+ case REJECTED_CURRENT_BRANCH:
+ case RENAMED:
default:
throw new IOException(String.format(
"Failed to update %s, RefUpdate.Result = %s", targetRef, result));
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/HttpResponse.java b/src/main/java/com/googlesource/gerrit/plugins/importer/HttpResponse.java
index 34786d3..4966c3c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/HttpResponse.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/HttpResponse.java
@@ -46,7 +46,9 @@
try {
Reader reader = getReader();
if (reader != null) {
- while (reader.read() != -1);
+ while (reader.read() != -1) {
+ // Empty
+ }
}
} finally {
response.close();
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/HttpSession.java b/src/main/java/com/googlesource/gerrit/plugins/importer/HttpSession.java
index 9fb8e27..531d176 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/HttpSession.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/HttpSession.java
@@ -20,7 +20,6 @@
import org.apache.http.auth.UsernamePasswordCredentials;
import org.apache.http.client.methods.HttpGet;
import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
-import org.apache.http.conn.ssl.X509HostnameVerifier;
import org.apache.http.impl.client.BasicCredentialsProvider;
import org.apache.http.impl.client.CloseableHttpClient;
import org.apache.http.impl.client.HttpClients;
@@ -31,10 +30,9 @@
import java.security.NoSuchAlgorithmException;
import java.security.cert.X509Certificate;
+import javax.net.ssl.HostnameVerifier;
import javax.net.ssl.SSLContext;
-import javax.net.ssl.SSLException;
import javax.net.ssl.SSLSession;
-import javax.net.ssl.SSLSocket;
import javax.net.ssl.TrustManager;
import javax.net.ssl.X509TrustManager;
@@ -106,28 +104,12 @@
}
}
- private static class DummyHostnameVerifier implements X509HostnameVerifier {
+ private static class DummyHostnameVerifier implements HostnameVerifier {
@Override
public boolean verify(String hostname, SSLSession session) {
// always accept
return true;
}
-
- @Override
- public void verify(String host, SSLSocket ssl) throws IOException {
- // no check
- }
-
- @Override
- public void verify(String host, X509Certificate cert) throws SSLException {
- // no check
- }
-
- @Override
- public void verify(String host, String[] cns, String[] subjectAlts)
- throws SSLException {
- // no check
- }
}
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/ImportMenu.java b/src/main/java/com/googlesource/gerrit/plugins/importer/ImportMenu.java
index ad9c37c..f0b0976 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/ImportMenu.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/ImportMenu.java
@@ -16,6 +16,7 @@
import com.google.common.collect.Lists;
import com.google.gerrit.extensions.annotations.PluginName;
+import com.google.gerrit.extensions.client.MenuItem;
import com.google.gerrit.extensions.webui.TopMenu;
import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.account.CapabilityControl;
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/ImportProject.java b/src/main/java/com/googlesource/gerrit/plugins/importer/ImportProject.java
index 39d1868..0e7d44a 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/ImportProject.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/ImportProject.java
@@ -47,7 +47,6 @@
import org.eclipse.jgit.lib.ProgressMonitor;
import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.lib.TextProgressMonitor;
-import org.eclipse.jgit.util.FS;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -302,7 +301,7 @@
private LockFile lockForImport() throws ResourceConflictException {
File importStatus = projects.FS_LAYOUT.getImportStatusFile(targetProject.get());
- LockFile lockFile = new LockFile(importStatus, FS.DETECTED);
+ LockFile lockFile = new LockFile(importStatus);
try {
if (lockFile.lock()) {
return lockFile;
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/InsertLinkToOriginalChangeStep.java b/src/main/java/com/googlesource/gerrit/plugins/importer/InsertLinkToOriginalChangeStep.java
index 6bee56c..27ead51 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/InsertLinkToOriginalChangeStep.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/InsertLinkToOriginalChangeStep.java
@@ -111,8 +111,12 @@
private ChangeControl control(Change change, Account.Id id)
throws NoSuchChangeException {
- return changeControlFactory.controlFor(change,
- genericUserFactory.create(id));
+ try {
+ return changeControlFactory.controlFor(db, change,
+ genericUserFactory.create(id));
+ } catch (OrmException e) {
+ throw new NoSuchChangeException(change.getId());
+ }
}
private static String ensureSlash(String in) {
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/Module.java b/src/main/java/com/googlesource/gerrit/plugins/importer/Module.java
index 1cad41f..7c2c2d4 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/Module.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/Module.java
@@ -16,8 +16,8 @@
import static com.google.gerrit.server.config.ConfigResource.CONFIG_KIND;
import static com.google.gerrit.server.project.ProjectResource.PROJECT_KIND;
-import static com.googlesource.gerrit.plugins.importer.ImportProjectResource.IMPORT_PROJECT_KIND;
import static com.googlesource.gerrit.plugins.importer.ImportGroupResource.IMPORT_GROUP_KIND;
+import static com.googlesource.gerrit.plugins.importer.ImportProjectResource.IMPORT_PROJECT_KIND;
import com.google.gerrit.extensions.annotations.Exports;
import com.google.gerrit.extensions.config.CapabilityDefinition;
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayChangesStep.java b/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayChangesStep.java
index 3322dfc..17a4345 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayChangesStep.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayChangesStep.java
@@ -26,6 +26,7 @@
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.server.ReviewDb;
+import com.google.gerrit.server.Sequences;
import com.google.gerrit.server.git.UpdateException;
import com.google.gerrit.server.index.ChangeIndexer;
import com.google.gerrit.server.project.NoSuchChangeException;
@@ -74,6 +75,7 @@
private final ReviewDb db;
private final ChangeIndexer indexer;
private final Provider<InternalChangeQuery> queryProvider;
+ private final Sequences sequences;
private final String fromGerrit;
private final GerritApi api;
private final Repository repo;
@@ -96,6 +98,7 @@
ReviewDb db,
ChangeIndexer indexer,
Provider<InternalChangeQuery> queryProvider,
+ Sequences sequences,
@Assisted @Nullable String fromGerrit,
@Assisted GerritApi api,
@Assisted Repository repo,
@@ -115,6 +118,7 @@
this.db = db;
this.indexer = indexer;
this.queryProvider = queryProvider;
+ this.sequences = sequences;
this.fromGerrit = fromGerrit;
this.api = api;
this.repo = repo;
@@ -220,7 +224,7 @@
private Change createChange(ChangeInfo c) throws OrmException,
NoSuchAccountException, IOException, RestApiException {
- Change.Id changeId = new Change.Id(db.nextChangeId());
+ Change.Id changeId = new Change.Id(sequences.nextChangeId());
Change change =
new Change(new Change.Key(c.changeId), changeId, accountUtil.resolveUser(api, c.owner),
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayInlineCommentsStep.java b/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayInlineCommentsStep.java
index 0df6a89..0015cc0 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayInlineCommentsStep.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayInlineCommentsStep.java
@@ -203,7 +203,7 @@
ChangeUpdate update = updateFactory.create(ctrl, TimeUtil.nowTs());
update.setPatchSetId(ps.getId());
plcUtil.deleteComments(db, update, del);
- plcUtil.upsertComments(db, update, ups);
+ plcUtil.putComments(db, update, ups);
update.commit();
}
@@ -220,7 +220,11 @@
private ChangeControl control(Change change, Account.Id id)
throws NoSuchChangeException {
- return changeControlFactory.controlFor(change,
- genericUserFactory.create(id));
+ try {
+ return changeControlFactory.controlFor(db, change,
+ genericUserFactory.create(id));
+ } catch (OrmException e) {
+ throw new NoSuchChangeException(change.getId());
+ }
}
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayMessagesStep.java b/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayMessagesStep.java
index c5ee3c5..e5a8975 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayMessagesStep.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayMessagesStep.java
@@ -107,7 +107,11 @@
private ChangeControl control(Change change, Account.Id id)
throws NoSuchChangeException {
- return changeControlFactory.controlFor(change,
+ try {
+ return changeControlFactory.controlFor(db, change,
genericUserFactory.create(id));
+ } catch (OrmException e) {
+ throw new NoSuchChangeException(change.getId());
+ }
}
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayRevisionsStep.java b/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayRevisionsStep.java
index 5adf74f..20559b6 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayRevisionsStep.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/ReplayRevisionsStep.java
@@ -23,7 +23,6 @@
import com.google.gerrit.reviewdb.client.PatchSetInfo;
import com.google.gerrit.reviewdb.client.RevId;
import com.google.gerrit.reviewdb.server.ReviewDb;
-import com.google.gerrit.server.ChangeUtil;
import com.google.gerrit.server.patch.PatchSetInfoFactory;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;
@@ -181,6 +180,13 @@
case FORCED:
case FAST_FORWARD:
return;
+ case IO_FAILURE:
+ case LOCK_FAILURE:
+ case NOT_ATTEMPTED:
+ case NO_CHANGE:
+ case REJECTED:
+ case REJECTED_CURRENT_BRANCH:
+ case RENAMED:
default:
throw new IOException(String.format(
"Failed to create ref %s, RefUpdate.Result = %s", ref, result));
diff --git a/src/main/java/com/googlesource/gerrit/plugins/importer/client/ResumeImportDialog.java b/src/main/java/com/googlesource/gerrit/plugins/importer/client/ResumeImportDialog.java
index c75b5eb..5b25ec4 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/importer/client/ResumeImportDialog.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/importer/client/ResumeImportDialog.java
@@ -14,8 +14,8 @@
package com.googlesource.gerrit.plugins.importer.client;
-import static com.googlesource.gerrit.plugins.importer.client.InputUtil.addPasswordTextBox;
import static com.googlesource.gerrit.plugins.importer.client.InputUtil.addCheckBox;
+import static com.googlesource.gerrit.plugins.importer.client.InputUtil.addPasswordTextBox;
import static com.googlesource.gerrit.plugins.importer.client.InputUtil.addTextBox;
import static com.googlesource.gerrit.plugins.importer.client.InputUtil.getValue;
@@ -87,6 +87,7 @@
p.add(new Label("Updated Changes: " + result.numChangesUpdated()));
Button okButton = new Button("OK");
okButton.addClickHandler(new ClickHandler() {
+ @Override
public void onClick(ClickEvent event) {
successDialog.hide();
}
