commit 99505c2c42897a79f5dc7c3570ef8cd177c9fded
author Edwin Kempin <edwin.kempin@sap.com> Fri Jan 31 16:34:41 2014 +0100
committer Edwin Kempin <edwin.kempin@sap.com> Sat Feb 01 09:39:09 2014 +0100
tree 55378ec6285f2ffad061dcbbcde6bdfe8e24f73d
parent 9240e63de8d8ce5a08356c023d80f5cfe3ec7a28

Prevent upload of non-image files already on client side

There is no need to send the file to the server if it is not an image
file (it will be rejected anyway).

Change-Id: I2e422b6678e62e8e50dfcca077c280db237b3ab0
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>

src/main/java/com/googlesource/gerrit/plugins/imagare/client/UploadByFileSelection.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/imagare/client/UploadByFileSelection.java b/src/main/java/com/googlesource/gerrit/plugins/imagare/client/UploadByFileSelection.java
index d7ede85..8c78e66 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/imagare/client/UploadByFileSelection.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/imagare/client/UploadByFileSelection.java
@@ -41,7 +41,11 @@
       if (f) {
         var r = new FileReader();
         r.onload = function(e) {
-          @com.googlesource.gerrit.plugins.imagare.client.ImageUploader::uploadImage(Ljava/lang/String;Ljava/lang/String;)(e.target.result, f.name);
+          if (f.type.match('image/.*')) {
+            @com.googlesource.gerrit.plugins.imagare.client.ImageUploader::uploadImage(Ljava/lang/String;Ljava/lang/String;)(e.target.result, f.name);
+          } else {
+            $wnd.Gerrit.showError('no image file');
+          }
         }
         r.readAsDataURL(f);
       }