commit 2402847cee1a24d8dec080cd9e31a754dd0ec890
author Christian Aistleitner <christian@quelltextlich.at> Sun Jan 27 22:44:55 2013 +0100
committer Christian Aistleitner <christian@quelltextlich.at> Mon Jan 28 20:59:39 2013 +0100
tree 03267c8c4ff1c63a38319cd827ca67e13af6abcf
parent 51c3ecb5b24cd51eb262054b8944b24ad243653d

Add logging of invalid actions

Change-Id: I4b4ed063de679db2fa569df1c7cd209660730b64

src/main/java/com/googlesource/gerrit/plugins/hooks/bz/BugzillaClient.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/hooks/bz/BugzillaClient.java b/src/main/java/com/googlesource/gerrit/plugins/hooks/bz/BugzillaClient.java
index 79c2be4..5abbf42 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/hooks/bz/BugzillaClient.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/hooks/bz/BugzillaClient.java
@@ -18,6 +18,9 @@
 import java.util.Map;
 import java.util.Set;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.j2bugzilla.base.Bug;
 import com.j2bugzilla.base.BugzillaConnector;
 import com.j2bugzilla.base.BugzillaException;
@@ -33,6 +36,8 @@
 
 public class BugzillaClient {
 
+  private Logger log = LoggerFactory.getLogger(BugzillaClient.class);
+
   private final BugzillaConnector connector;
   private final String xmlRpcUrl;
   private static HashMap<Fields, Set<String>> legalFieldValues = new HashMap<Fields, Set<String>>();
@@ -81,6 +86,9 @@
       } else if (actionName.equals("resolution")) {
         bug.setResolution(actionValue);
       }
+    } else {
+      log.warn( "Action '" + actionName + "' with value '" + actionValue
+        + "' is not valid. Skipping action on issue " + bugId + "." );
     }
     connector.executeMethod(new UpdateBug(bug));
   }