commit fea8d39afb227709065839dab812eb27ae87f9c4
author Eryk Szymanski <eryksz@gmail.com> Thu Nov 23 18:29:26 2017 +0100
committer David Pursehouse <dpursehouse@collab.net> Fri Nov 24 15:53:05 2017 +0900
tree ff84cc71354f312ce5758a68f1f6a7f8ca17a692
parent cdea6c0c2dcb09ff68bf0914a693fa7969e9207e

Fix usage of DEFAULT_SKIP_INTERFACE_LIST

As the getStringList() from Config does not return null
the DEFAULT_SKIP_INTERFACE_LIST was never used.
Now we check the length of the returned array if it is 0
we use DEFAULT_SKIP_INTEFACE_LIST

Change-Id: Ic8a1ca6275d48270c20ebe9417290555acd9d155
Signed-off-by: Eryk Szymanski <eryksz@gmail.com>

src/main/java/com/ericsson/gerrit/plugins/highavailability/Configuration.java

diff --git a/src/main/java/com/ericsson/gerrit/plugins/highavailability/Configuration.java b/src/main/java/com/ericsson/gerrit/plugins/highavailability/Configuration.java
index 7abad3d..f409119 100644
--- a/src/main/java/com/ericsson/gerrit/plugins/highavailability/Configuration.java
+++ b/src/main/java/com/ericsson/gerrit/plugins/highavailability/Configuration.java
@@ -248,7 +248,7 @@
 
     private PeerInfoJGroups(Config cfg) {
       String[] skip = cfg.getStringList(PEER_INFO_SECTION, JGROUPS_SUBSECTION, SKIP_INTERFACE_KEY);
-      skipInterface = skip == null ? DEFAULT_SKIP_INTERFACE_LIST : ImmutableList.copyOf(skip);
+      skipInterface = skip.length == 0 ? DEFAULT_SKIP_INTERFACE_LIST : ImmutableList.copyOf(skip);
       clusterName =
           getString(
               cfg, PEER_INFO_SECTION, JGROUPS_SUBSECTION, CLUSTER_NAME_KEY, DEFAULT_CLUSTER_NAME);