Catch all exceptions when indexTs fails
Report *any* sort of exception to the Gerrit error log
when the update of the latest index timestamp fails for any reason.
The update of indexTs is not severe enough to break the entire
indexing chain of events. Instead of having more diagnostics on what
failed and why it is far more useful than breaking the execution.
It isn't generally a good practice to catch RuntimeExceptions,
however, in this case, it is more "reporting them" rather than trying
to recover.
Change-Id: I3fb6c4e6a5b67d7ac0cdf19a1afa0695bfd0da16
diff --git a/src/main/java/com/ericsson/gerrit/plugins/highavailability/autoreindex/IndexTs.java b/src/main/java/com/ericsson/gerrit/plugins/highavailability/autoreindex/IndexTs.java
index b491468..387c7ad 100644
--- a/src/main/java/com/ericsson/gerrit/plugins/highavailability/autoreindex/IndexTs.java
+++ b/src/main/java/com/ericsson/gerrit/plugins/highavailability/autoreindex/IndexTs.java
@@ -24,7 +24,6 @@
import com.google.gerrit.server.ChangeFinder;
import com.google.gerrit.server.git.WorkQueue;
import com.google.gerrit.server.notedb.ChangeNotes;
-import com.google.gwtorm.server.OrmException;
import com.google.gwtorm.server.SchemaFactory;
import com.google.inject.Inject;
import com.google.inject.Singleton;
@@ -109,7 +108,7 @@
changeNotes == null
? LocalDateTime.now()
: changeNotes.getChange().getLastUpdatedOn().toLocalDateTime());
- } catch (OrmException e) {
+ } catch (Exception e) {
log.warn("Unable to update the latest TS for change {}", e);
}
}
