commit a22349df47a08bd9fad0efdac8cf73ba1a1d8163
author Marco Miller <marco.miller@ericsson.com> Fri Nov 16 18:50:08 2018 -0500
committer Marco Miller <marco.miller@ericsson.com> Fri Nov 16 18:50:10 2018 -0500
tree f52b60f52dd96d32f0ee42960798696c51960fd9
parent 3dd9bcd75de95c75b92226ded2cd23fd173e5cf0

Setup: Rename the number-to-string conversion methods

Make their name more explicit.

Change-Id: I238d247e71f4babcbaedf5d8bd5336fe4b65525f

src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java

diff --git a/src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java b/src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java
index 5db6959..217e644 100644
--- a/src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java
+++ b/src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java
@@ -121,12 +121,17 @@
     config.setBoolean(AUTO_REINDEX_SECTION, null, ENABLED, autoReindex);
 
     String delay =
-        promptAndSetString("Delay", AUTO_REINDEX_SECTION, null, DELAY, str(DEFAULT_DELAY));
+        promptAndSetString(
+            "Delay", AUTO_REINDEX_SECTION, null, DELAY, numberToString(DEFAULT_DELAY));
     config.setLong(AUTO_REINDEX_SECTION, null, DELAY, Long.valueOf(delay));
 
     String pollInterval =
         promptAndSetString(
-            "Poll interval", AUTO_REINDEX_SECTION, null, POLL_INTERVAL, str(DEFAULT_POLL_INTERVAL));
+            "Poll interval",
+            AUTO_REINDEX_SECTION,
+            null,
+            POLL_INTERVAL,
+            numberToString(DEFAULT_POLL_INTERVAL));
     config.setLong(AUTO_REINDEX_SECTION, null, POLL_INTERVAL, Long.valueOf(pollInterval));
   }
 
@@ -168,13 +173,22 @@
         "Max number of tries to forward to remote peer",
         HTTP_SECTION,
         MAX_TRIES_KEY,
-        str(DEFAULT_MAX_TRIES));
+        numberToString(DEFAULT_MAX_TRIES));
     promptAndSetString(
-        "Retry interval [ms]", HTTP_SECTION, RETRY_INTERVAL_KEY, str(DEFAULT_RETRY_INTERVAL));
+        "Retry interval [ms]",
+        HTTP_SECTION,
+        RETRY_INTERVAL_KEY,
+        numberToString(DEFAULT_RETRY_INTERVAL));
     promptAndSetString(
-        "Connection timeout [ms]", HTTP_SECTION, CONNECTION_TIMEOUT_KEY, str(DEFAULT_TIMEOUT_MS));
+        "Connection timeout [ms]",
+        HTTP_SECTION,
+        CONNECTION_TIMEOUT_KEY,
+        numberToString(DEFAULT_TIMEOUT_MS));
     promptAndSetString(
-        "Socket timeout [ms]", HTTP_SECTION, SOCKET_TIMEOUT_KEY, str(DEFAULT_TIMEOUT_MS));
+        "Socket timeout [ms]",
+        HTTP_SECTION,
+        SOCKET_TIMEOUT_KEY,
+        numberToString(DEFAULT_TIMEOUT_MS));
   }
 
   private void configureCacheSection() {
@@ -183,7 +197,7 @@
         "Cache thread pool size",
         CACHE_SECTION,
         THREAD_POOL_SIZE_KEY,
-        str(DEFAULT_THREAD_POOL_SIZE));
+        numberToString(DEFAULT_THREAD_POOL_SIZE));
   }
 
   private void configureIndexSection() {
@@ -192,7 +206,7 @@
         "Index thread pool size",
         INDEX_SECTION,
         THREAD_POOL_SIZE_KEY,
-        str(DEFAULT_THREAD_POOL_SIZE));
+        numberToString(DEFAULT_THREAD_POOL_SIZE));
   }
 
   private void configureWebsessionsSection() {
@@ -230,12 +244,12 @@
     return newValue;
   }
 
-  private static String str(int n) {
-    return Integer.toString(n);
+  private static String numberToString(int number) {
+    return Integer.toString(number);
   }
 
-  private static String str(long n) {
-    return Long.toString(n);
+  private static String numberToString(long number) {
+    return Long.toString(number);
   }
 
   private boolean createHAReplicaSite(FileBasedConfig pluginConfig)