commit 95be9b73d5c859b94a99aed9df4d231f349cf7ea
author Saša Živkov <sasa.zivkov@sap.com> Tue Jun 20 11:16:17 2017 +0200
committer Saša Živkov <sasa.zivkov@sap.com> Tue Jun 20 11:16:17 2017 +0200
tree cec86f98ae1c9860e2a9ab8c57325a1263e7f5d3
parent e4ee72bc499904ee81b3278fe47fd9f631b277fd

Use Strings.isNullOrEmpty instead of just null check

Change-Id: Id46cfee896415b8437febd8e8a8abe6dd864c11c

src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java

diff --git a/src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java b/src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java
index b0d9ed6..dfb4887 100644
--- a/src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java
+++ b/src/main/java/com/ericsson/gerrit/plugins/highavailability/Setup.java
@@ -66,7 +66,7 @@
     ui.header("Main section");
     String sharedDir =
         promptAndSetString("Shared directory", MAIN_SECTION, SHARED_DIRECTORY_KEY, null);
-    if (sharedDir != null) {
+    if (!Strings.isNullOrEmpty(sharedDir)) {
       Path shared = site.site_path.resolve(sharedDir);
       FileUtil.mkdirsOrDie(shared, "cannot create " + shared);
     }
@@ -123,7 +123,7 @@
     String oldValue = Strings.emptyToNull(config.getString(section, null, name));
     String newValue = ui.readString(oldValue != null ? oldValue : defaultValue, title);
     if (!Objects.equals(oldValue, newValue)) {
-      if (newValue != null) {
+      if (!Strings.isNullOrEmpty(newValue)) {
         config.setString(section, null, name, newValue);
       } else {
         config.unset(section, name, name);