Drop tests asserting defaults on invalid time units Parsing invalid time units now throws IllegalArgumentException (since change I23f5586e1f6) instead of silently falling back to defaults. The high-availability configuration tests were still asserting that an invalid value should yield the default, which no longer reflects the current contract and caused brittle failures. This change removes those assertions from ConfigurationTest for: - http.connectionTimeout - http.socketTimeout - http.retryInterval Rationale: - These checks verify ConfigUtil’s parsing behavior, which is already covered by its own test suite. - The plugin does not promise a default-on-error fallback; encoding that expectation in its tests is misleading. - Dropping the assertions decouples the plugin tests from lower-level parsing details and prevents false failures after the API change. Bug: Issue 445404588 Change-Id: Ie112b7dce05d35cdd4e4e3028c38b0d7d0d660b4
diff --git a/src/test/java/com/ericsson/gerrit/plugins/highavailability/ConfigurationTest.java b/src/test/java/com/ericsson/gerrit/plugins/highavailability/ConfigurationTest.java index b51e1a0..0fb7dad 100644 --- a/src/test/java/com/ericsson/gerrit/plugins/highavailability/ConfigurationTest.java +++ b/src/test/java/com/ericsson/gerrit/plugins/highavailability/ConfigurationTest.java
@@ -217,9 +217,6 @@ globalPluginConfig.setInt(HTTP_SECTION, null, CONNECTION_TIMEOUT_KEY, TIMEOUT); assertThat(getConfiguration().http().connectionTimeout().toMillis()).isEqualTo(TIMEOUT); - - globalPluginConfig.setString(HTTP_SECTION, null, CONNECTION_TIMEOUT_KEY, INVALID_INT); - assertThat(getConfiguration().http().connectionTimeout()).isEqualTo(DEFAULT_TIMEOUT); } @Test @@ -228,9 +225,6 @@ globalPluginConfig.setInt(HTTP_SECTION, null, SOCKET_TIMEOUT_KEY, TIMEOUT); assertThat(getConfiguration().http().socketTimeout().toMillis()).isEqualTo(TIMEOUT); - - globalPluginConfig.setString(HTTP_SECTION, null, SOCKET_TIMEOUT_KEY, INVALID_INT); - assertThat(getConfiguration().http().socketTimeout()).isEqualTo(DEFAULT_TIMEOUT); } @Test @@ -256,9 +250,6 @@ globalPluginConfig.setInt(HTTP_SECTION, null, RETRY_INTERVAL_KEY, RETRY_INTERVAL); assertThat(getConfiguration().http().retryInterval().toMillis()).isEqualTo(RETRY_INTERVAL); - - globalPluginConfig.setString(HTTP_SECTION, null, RETRY_INTERVAL_KEY, INVALID_INT); - assertThat(getConfiguration().http().retryInterval()).isEqualTo(DEFAULT_RETRY_INTERVAL); } @Test