commit 6781be436efc446650c53eeb3b43629864e87975
author David Pursehouse <dpursehouse@collab.net> Mon Jul 24 08:21:13 2017 +0100
committer David Pursehouse <dpursehouse@collab.net> Fri Feb 23 08:35:41 2018 +0900
tree cc922a21682bfadb287b3aab51afa5b671e00f01
parent a69147251d1dd9bc7afe82138849f94032e7ec35

IndexEventHandlerTest: Fix 'Unlikely argument type' Eclipse warnings

Eclipse 4.7.0 (Oxygen) introduced a new compiler warning:

  Unlikely argument type

In this case the warning is being emitted because a String is being
passed in place of Index{Account|Change|Group}Task instance.

Replace these with dummy instances of the expected class.

Change-Id: I2c44501c4e0da63f88ad22d1a4a91ff55bed025c

src/test/java/com/ericsson/gerrit/plugins/highavailability/index/IndexEventHandlerTest.java

diff --git a/src/test/java/com/ericsson/gerrit/plugins/highavailability/index/IndexEventHandlerTest.java b/src/test/java/com/ericsson/gerrit/plugins/highavailability/index/IndexEventHandlerTest.java
index e50d713..60c5ab7 100644
--- a/src/test/java/com/ericsson/gerrit/plugins/highavailability/index/IndexEventHandlerTest.java
+++ b/src/test/java/com/ericsson/gerrit/plugins/highavailability/index/IndexEventHandlerTest.java
@@ -143,7 +143,7 @@
     assertThat(task.hashCode()).isEqualTo(identicalTask.hashCode());
 
     assertThat(task.equals(null)).isFalse();
-    assertThat(task.equals("test")).isFalse();
+    assertThat(task.equals(indexEventHandler.new IndexChangeTask(CHANGE_ID + 1, false))).isFalse();
     assertThat(task.hashCode()).isNotEqualTo("test".hashCode());
 
     IndexChangeTask differentChangeIdTask = indexEventHandler.new IndexChangeTask(123, false);
@@ -167,7 +167,7 @@
     assertThat(task.hashCode()).isEqualTo(identicalTask.hashCode());
 
     assertThat(task.equals(null)).isFalse();
-    assertThat(task.equals("test")).isFalse();
+    assertThat(task.equals(indexEventHandler.new IndexAccountTask(ACCOUNT_ID + 1))).isFalse();
     assertThat(task.hashCode()).isNotEqualTo("test".hashCode());
 
     IndexAccountTask differentAccountIdTask = indexEventHandler.new IndexAccountTask(123);