commit af3953754fc96433f69e2cbb888676a46b94c0f1
author Tiago Palma <tiago.f.palma@gmail.com> Tue Feb 26 11:31:59 2019 +0100
committer Luca Milanesio <luca.milanesio@gmail.com> Tue Feb 26 23:52:57 2019 +0000
tree 0b23cb4b1676d4188c7cf4029ae6841d2db0d867
parent 7f2dca468a6ac59851d63f5c29927ab083ee86c5

Fix typo when getting auth username from configuration file

Adds also a couple of unit tests to HealthCheckConfigTest.

Change-Id: Ia659a03856963e2af43ca7d69e2619f4eaad367f

src/main/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfig.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfig.java b/src/main/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfig.java
index 5e1c7ea..d7ab48e 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfig.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfig.java
@@ -100,7 +100,7 @@
   }
 
   public String getUsername(String healthCheckName) {
-    return getStringWithFallback("userame", healthCheckName, USERNAME_DEFAULT);
+    return getStringWithFallback("username", healthCheckName, USERNAME_DEFAULT);
   }
 
   public String getPassword(String healthCheckName) {

src/test/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfigTest.java

diff --git a/src/test/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfigTest.java b/src/test/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfigTest.java
index fc215ff..102e246 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfigTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckConfigTest.java
@@ -37,6 +37,22 @@
   }
 
   @Test
+  public void shouldHaveAuthUsername() {
+    HealthCheckConfig config =
+        new HealthCheckConfig("[healthcheck \"auth\"]\n" + "username=test_user");
+
+    assertThat(config.getUsername("auth")).isEqualTo("test_user");
+  }
+
+  @Test
+  public void shouldHaveAuthPassword() {
+    HealthCheckConfig config =
+        new HealthCheckConfig("[healthcheck \"auth\"]\n" + "password=secret");
+
+    assertThat(config.getPassword("auth")).isEqualTo("secret");
+  }
+
+  @Test
   public void shouldHaveCheckOverriddenTimeout() {
     HealthCheckConfig config =
         new HealthCheckConfig(