Removal all references to ReviewDb ReviewDb does not exist anymore on Gerrit master, remove any references to it as they are misleading. Change-Id: Ic3dff4ce02a96d792d34b197bfb58ad246123bac
diff --git a/src/main/resources/Documentation/config.md b/src/main/resources/Documentation/config.md index d1f39c6..0a9fa22 100644 --- a/src/main/resources/Documentation/config.md +++ b/src/main/resources/Documentation/config.md
@@ -19,11 +19,6 @@ "elapsed": 20, "result": "passed" }, - "reviewdb": { - "ts": 139402910202, - "elapsed": 50, - "result": "passed" - }, "projectslist": { "ts": 139402910202, "elapsed": 100, @@ -50,7 +45,6 @@ The following check names are available: - `querychanges`: check the ability to query changes -- `reviewdb` : check connectivity and ability to query ReviewDb - `jgit` : check connectivity to the filesystem and ability to open a JGit ref and object - `projectslist` : check the ability to list projects with their descriptions @@ -75,4 +69,4 @@ Multiple occurrences are allowed to configure more projects, in addition to the default ones that are always included. - Default: All-Projects, All-Users \ No newline at end of file + Default: All-Projects, All-Users
diff --git a/src/resources/Documentation/config.md b/src/resources/Documentation/config.md index ea51c10..aa59c29 100644 --- a/src/resources/Documentation/config.md +++ b/src/resources/Documentation/config.md
@@ -48,9 +48,6 @@ # TYPE plugins_healthcheck_projectslist_latest_measured_latency gauge plugins_healthcheck_projectslist_latest_measured_latency 5.0 -# HELP plugins_healthcheck_reviewdb_latest_measured_latency Generated from Dropwizard metric import (metric=plugins/healthcheck/reviewdb/latency, type=com.google.gerrit.metrics.dropwizard.CallbackMetricImpl0$1) -# TYPE plugins_healthcheck_reviewdb_latest_measured_latency gauge -plugins_healthcheck_reviewdb_latest_measured_latency 3.0 # HELP plugins_healthcheck_jgit_failure_total Generated from Dropwizard metric import (metric=plugins/healthcheck/jgit/failure, type=com.codahale.metrics.Meter) # TYPE plugins_healthcheck_jgit_failure_total counter @@ -59,10 +56,6 @@ # HELP plugins_healthcheck_projectslist_failure_total Generated from Dropwizard metric import (metric=plugins/healthcheck/projectslist/failure, type=com.codahale.metrics.Meter) # TYPE plugins_healthcheck_projectslist_failure_total counter plugins_healthcheck_projectslist_failure_total 0.0 - -# HELP plugins_healthcheck_reviewdb_failure_total Generated from Dropwizard metric import (metric=plugins/healthcheck/reviewdb/failure, type=com.codahale.metrics.Meter) -# TYPE plugins_healthcheck_reviewdb_failure_total counter -plugins_healthcheck_reviewdb_failure_total 0.0 ``` Metrics will be exposed to prometheus by the [metrics-reporter-prometheus](https://gerrit.googlesource.com/plugins/metrics-reporter-prometheus/) plugin.
diff --git a/src/test/java/com/googlesource/gerrit/plugins/healthcheck/JGitHealthCheckTest.java b/src/test/java/com/googlesource/gerrit/plugins/healthcheck/JGitHealthCheckTest.java index 1a8ec63..59dfd71 100644 --- a/src/test/java/com/googlesource/gerrit/plugins/healthcheck/JGitHealthCheckTest.java +++ b/src/test/java/com/googlesource/gerrit/plugins/healthcheck/JGitHealthCheckTest.java
@@ -67,9 +67,9 @@ @Test public void shouldBeHealthyWhenJGitIsWorking() { - JGitHealthCheck reviewDbCheck = + JGitHealthCheck check = new JGitHealthCheck(executor, DEFAULT_CONFIG, getWorkingRepositoryManager()); - assertThat(reviewDbCheck.run().result).isEqualTo(Result.PASSED); + assertThat(check.run().result).isEqualTo(Result.PASSED); } @Test