| commit | 075144dc105cfe9cb5fc298efd8f8d1f5eed3670 | [log] [tgz] |
|---|---|---|
| author | Tiago Palma <tiago.f.palma@gmail.com> | Fri Mar 15 17:40:59 2019 +0000 |
| committer | Tiago Palma <tiago.f.palma@gmail.com> | Sun Mar 17 19:59:47 2019 +0000 |
| tree | 90a5975d4d190813e960bbabf720a75671a68ec9 | |
| parent | 6fdc558b5fb48300113fe74d66cc58903326ac4f [diff] |
HC returns 500 only with TIMEOUT or FAILED The getResultStatus method should return 500 only if Result is a TIMEOUT or FAILED. Feature: Issue 10610 Change-Id: I23e61ef8e33b5737c58b6d0cf12eb6df96c95191
diff --git a/src/main/java/com/googlesource/gerrit/plugins/healthcheck/api/HealthCheckStatusEndpoint.java b/src/main/java/com/googlesource/gerrit/plugins/healthcheck/api/HealthCheckStatusEndpoint.java index 26a2042..c508222 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/healthcheck/api/HealthCheckStatusEndpoint.java +++ b/src/main/java/com/googlesource/gerrit/plugins/healthcheck/api/HealthCheckStatusEndpoint.java
@@ -51,7 +51,7 @@ .filter( res -> res instanceof HealthCheck.StatusSummary - && ((HealthCheck.StatusSummary) res).result != HealthCheck.Result.PASSED) + && ((HealthCheck.StatusSummary) res).isFailure()) .findFirst() .isPresent()) { return HttpServletResponse.SC_INTERNAL_SERVER_ERROR;