Fix 'Statement unnecessarily nested within else clause' warnings
Change-Id: I01ac58b4d964444ee41d6029225fba9213b60500
diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitiles/GerritGitilesAccess.java b/src/main/java/com/googlesource/gerrit/plugins/gitiles/GerritGitilesAccess.java
index 30bfddf..d7af64e 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitiles/GerritGitilesAccess.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitiles/GerritGitilesAccess.java
@@ -134,9 +134,8 @@
CurrentUser user = userProvider.get();
if (user instanceof IdentifiedUser) {
return ((IdentifiedUser) user).getAccountId();
- } else {
- return anonymousCowardName;
}
+ return anonymousCowardName;
}
@Override
diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitiles/Resolver.java b/src/main/java/com/googlesource/gerrit/plugins/gitiles/Resolver.java
index 63db101..f47d7c0 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitiles/Resolver.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitiles/Resolver.java
@@ -64,12 +64,11 @@
} catch (NoSuchProjectException e) {
if (userProvider.get().isIdentifiedUser()) {
throw new RepositoryNotFoundException(name, e);
- } else {
- // Allow anonymous users a chance to login.
- // Avoid leaking information by not distinguishing between
- // project not existing and no access rights.
- throw new ServiceNotAuthorizedException();
}
+ // Allow anonymous users a chance to login.
+ // Avoid leaking information by not distinguishing between
+ // project not existing and no access rights.
+ throw new ServiceNotAuthorizedException();
} catch (IOException e) {
ServiceMayNotContinueException err =
new ServiceMayNotContinueException("error opening repository " + name);
