commit c5c76db62048bfcaae29aeb9154c3a67cf51ac4c
author David Pursehouse <david.pursehouse@sonymobile.com> Fri Oct 23 19:00:44 2015 +0900
committer Luca Milanesio <luca.milanesio@gmail.com> Sun Oct 25 15:46:15 2015 +0000
tree ae9b367b43a934220816c6c48fd91da4190e5842
parent 60525c1bbf745b268f3852707d46b24246d1fecb

OAuthWebFilter: Fix 'parameter should not be assigned' warning

Don't assign a new value to the parameter that was passed
into the method.  Use the locally created copy.

Change-Id: I3a4c8ff3da6f3d0adf45cf77794459dd67595525

github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthWebFilter.java

diff --git a/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthWebFilter.java b/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthWebFilter.java
index cde4fbf..2c2afb2 100644
--- a/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthWebFilter.java
+++ b/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthWebFilter.java
@@ -89,7 +89,8 @@
         login(request, httpRequest, httpResponse, ghLogin);
       } else {
         if (OAuthProtocol.isOAuthLogout(httpRequest)) {
-          response = logout(request, response, chain, httpRequest);
+          httpResponse =
+              (HttpServletResponse) logout(request, httpResponse, chain, httpRequest);
         }
 
         if (ghLogin != null && ghLogin.isLoggedIn()) {
@@ -99,7 +100,7 @@
                   GITHUB_EXT_ID + ghLogin.getToken().accessToken);
         }
 
-        chain.doFilter(httpRequest, response);
+        chain.doFilter(httpRequest, httpResponse);
       }
     } finally {
       HttpSession httpSession = httpRequest.getSession();