Update README.md and pom.xml to allow Java 8 build
Gerrit 3.3 allows to build and run Gerrit and its plugins
on Java 8. Update the pom.xml files and the instructions to
allow building and running as expected.
The default parameters run a build against Java 11, aligned
with Gerrit default build and distribution.
Change-Id: I19668e57d5448248aca675cde34094f4a86f894a
diff --git a/README.md b/README.md
index a914ac0..018f4d0 100644
--- a/README.md
+++ b/README.md
@@ -66,14 +66,25 @@
How to build this plugin
------------------------
-### Gerrit 2.10 build
+### Gerrit 3.3 build
-GitHub plugin is designed to work with Gerrit 2.10 (currently in development).
-In order to build the GitHub plugin you need to have a working Gerrit 2.10
+GitHub plugin is designed to work with Gerrit 3.3 (currently in development).
+In order to build the GitHub plugin you need to have a working Gerrit 3.3
build in place.
-See https://gerrit-review.googlesource.com/Documentation/dev-buck.html for a
-reference on how to build Gerrit 2.10 (master branch) using BUCK.
+See https://gerrit-review.googlesource.com/Documentation/dev-bazel.html for a
+reference on how to build Gerrit using Bazel.
+
+Gerrit 3.3 is distributed for Java 11 only. However, the source code is compatible
+with Java 8 assuming you build it from the source repository by yourself.
+
+The GitHub plugin can be built for Java 8 by using the `javaVersion=1.8` Maven
+parameter.
+
+Example:
+ git clone https://gerrit.googlesource.com/plugins/github
+ cd github
+ mvn -DjavaVersion=1.8 install
### GitHub API
@@ -90,17 +101,17 @@
### singleusergroup plugin
-You need to clone, build and install the singleusergroup plugin for Gerrit
+You need to install the singleusergroup plugin for Gerrit
(see https://gerrit-review.googlesource.com/#/admin/projects/plugins/singleusergroup).
This plugin is needed to allow Gerrit to use individual users as Groups for being
-used in Gerrit ACLs. As of Gerrit 2.10 singleuserplugin is a core plugin and
+used in Gerrit ACLs. As of Gerrit 3.3 singleuserplugin is a core plugin and
included in Gerrit tree (if it was cloned recursively).
Example:
cd gerrit
- buck build plugins/singleusergroup
- cp buck-out/gen/plugins/singleusergroup/singleusergroup.jar $GERRIT_SITE/plugins/.
+ bazelisk build plugins/singleusergroup
+ cp bazel-bin/plugins/singleusergroup/singleusergroup.jar $GERRIT_SITE/plugins/.
### Building GitHub integration for Gerrit
diff --git a/pom.xml b/pom.xml
index cbdf789..7c50af1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,6 +22,9 @@
<name>Gerrit Code Review - GitHub integration</name>
<url>http://www.gerritforge.com</url>
<packaging>pom</packaging>
+ <properties>
+ <javaVersion>11</javaVersion>
+ </properties>
<licenses>
<license>
<name>Apache License, 2.0</name>
@@ -241,8 +244,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.1</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>${javaVersion}</source>
+ <target>${javaVersion}</target>
</configuration>
</plugin>
</plugins>
